linux-kernel - Re: [PATCH 6.1 000/321] 6.1.107-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtBljcXHrUdvglG0@duo.ucw.cz>
Date: Thu, 29 Aug 2024 14:11:57 +0200
From: Pavel Machek <pavel@...x.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Pavel Machek <pavel@...x.de>, stable@...r.kernel.org,
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
	lkft-triage@...ts.linaro.org, jonathanh@...dia.com,
	f.fainelli@...il.com, sudipm.mukherjee@...il.com,
	srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
	allen.lkml@...il.com, broonie@...nel.org, kuba@...nel.org,
	linan122@...wei.com, dsterba@...e.com, song@...nel.org,
	tglx@...utronix.de, viro@...iv.linux.org.uk,
	christian.brauner@...ntu.com, keescook@...omium.org
Subject: Re: [PATCH 6.1 000/321] 6.1.107-rc1 review

On Thu 2024-08-29 13:52:59, Greg Kroah-Hartman wrote:
> On Thu, Aug 29, 2024 at 01:37:40PM +0200, Pavel Machek wrote:
> > > Christian Brauner <brauner@...nel.org>
> > >     binfmt_misc: cleanup on filesystem umount
> > 
> > Changelog explains how this may cause problems. It does not fix a
> > bug. It is overly long. It does not have proper signoff by stable team.
> 
> The sign off is there, it's just further down than you might expect.

Is it? Who signed this off for stable?

cf7602cbd58246d02a8544e4f107658fe846137a

    In line with our general policy, if we see a regression for systemd or
    other users with this change we will switch back to the old behavior for
    the initial binfmt_misc mount and have binary types pin the filesystem
    again. But while we touch this code let's take the chance and let's
    improve on the status quo.
    
    [1]: https://lore.kernel.org/r/20191216091220.465626-2-laurent@vivier.eu
    [2]: commit 43a4f2619038 ("exec: binfmt_misc: fix race between load_misc_binary() and kill_node()"
    [3]: commit 83f918274e4b ("exec: binfmt_misc: shift filp_close(interp_file) from kill_node() to bm_evict_inode()")
    [4]: commit f0fe2c0f050d ("binder: prevent UAF for binderfs devices II")
    
    Link: https://lore.kernel.org/r/20211028103114.2849140-1-brauner@kernel.org (v1)
    Cc: Sargun Dhillon <sargun@...gun.me>
    Cc: Serge Hallyn <serge@...lyn.com>
    Cc: Jann Horn <jannh@...gle.com>
    Cc: Henning Schild <henning.schild@...mens.com>
    Cc: Andrei Vagin <avagin@...il.com>
    Cc: Al Viro <viro@...iv.linux.org.uk>
    Cc: Laurent Vivier <laurent@...ier.eu>
    Cc: linux-fsdevel@...r.kernel.org
    Acked-by: Serge Hallyn <serge@...lyn.com>
    Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
    Signed-off-by: Christian Brauner <brauner@...nel.org>
    Signed-off-by: Kees Cook <keescook@...omium.org>

Regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)