linux-kernel - Re: [PATCH v2 5/7] i2c: npcm: Modify the client address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACD3sJbZ-Yy3PfPWisMSiPYCbztbi1+Q+=udMG8EjNvE+xA1mg@mail.gmail.com>
Date: Mon, 2 Sep 2024 09:40:09 +0800
From: Tyrone Ting <warp5tw@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, avifishman70@...il.com, 
	tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com, 
	yuenn@...gle.com, benjaminfair@...gle.com, andi.shyti@...nel.org, 
	wsa@...nel.org, rand.sec96@...il.com, wsa+renesas@...g-engineering.com, 
	tali.perry@...oton.com, avi.fishman@...oton.com, tomer.maimon@...oton.com, 
	kwliu@...oton.com, jjliu0@...oton.com, kfting@...oton.com
Cc: openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] i2c: npcm: Modify the client address assignment

Hi Andy:

Thank you for your comments.

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> 於 2024年8月31日 週六 上午3:16寫道：
>
> On Fri, Aug 30, 2024 at 11:46:38AM +0800, Tyrone Ting wrote:
> > Store the client address earlier since it's used in the i2c_recover_bus
> > logic flow.
>
> Here no explanation why it's now left-shifted by one bit.

The address is stored from bit 1 to bit 7 in the register for sending
the i2c address later.
I'll write some comments about the left-shifted by one bit behavior
above this modification in next patch set.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Thank you.

Regards,
Tyrone