linux-kernel - Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvLZWqRFnAtgFo3B@lizhi-Precision-Tower-5810>
Date: Tue, 24 Sep 2024 11:23:06 -0400
From: Frank Li <Frank.li@....com>
To: Conor Dooley <conor@...nel.org>
Cc: Richard Zhu <hongxing.zhu@....com>, l.stach@...gutronix.de,
	kwilczynski@...nel.org, bhelgaas@...gle.com, lpieralisi@...nel.org,
	robh+dt@...nel.org, conor+dt@...nel.org, shawnguo@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, festevam@...il.com,
	s.hauer@...gutronix.de, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, kernel@...gutronix.de,
	imx@...ts.linux.dev
Subject: Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95
 PCIe

On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote:
> On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote:
> > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5 and
> > keep the same restriction with other compatible string.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
>
> It'd be really good to mention why this clock is appearing now, when it
> did not before. You're just explaining what you've done, which can be
> seen in the diff, but not why you did it.

Previous reference clock of i.MX95 is on when system boot to kernel. But
boot firmware change the behavor, so it is off when boot. So it need be
turn on when it use. Also it need be turn off/on when suspend and resume.
Previous miss this feature.

Frank