linux-kernel - Re: [PATCH V3 1/1] livepatch: Add "stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240930232600.ku2zkttvvkxngdmc@treble>
Date: Mon, 30 Sep 2024 16:26:00 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Wardenjohn <zhangwarden@...il.com>
Cc: mbenes@...e.cz, jikos@...nel.org, pmladek@...e.com,
	joe.lawrence@...hat.com, live-patching@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 1/1] livepatch: Add "stack_order" sysfs attribute

On Sun, Sep 29, 2024 at 10:43:34PM +0800, Wardenjohn wrote:
> Add "stack_order" sysfs attribute which holds the order in which a live
> patch module was loaded into the system. A user can then determine an
> active live patched version of a function.
> 
> cat /sys/kernel/livepatch/livepatch_1/stack_order -> 1
> 
> means that livepatch_1 is the first live patch applied
> 
> cat /sys/kernel/livepatch/livepatch_module/stack_order -> N
> 
> means that livepatch_module is the Nth live patch applied
> 
> Suggested-by: Petr Mladek <pmladek@...e.com>
> Suggested-by: Miroslav Benes <mbenes@...e.cz>
> Suggested-by: Josh Poimboeuf <jpoimboe@...nel.org>
> Signed-off-by: Wardenjohn <zhangwarden@...il.com>
> ---
>  .../ABI/testing/sysfs-kernel-livepatch        |  8 ++++++
>  kernel/livepatch/core.c                       | 25 +++++++++++++++++++
>  2 files changed, 33 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-kernel-livepatch b/Documentation/ABI/testing/sysfs-kernel-livepatch
> index a5df9b4910dc..2a60b49aa9a5 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-livepatch
> +++ b/Documentation/ABI/testing/sysfs-kernel-livepatch
> @@ -47,6 +47,14 @@ Description:
>  		disabled when the feature is used. See
>  		Documentation/livepatch/livepatch.rst for more information.
>  
> +What:           /sys/kernel/livepatch/<patch>/stack_order
> +Date:           Sep 2024
> +KernelVersion:  6.12.0

These will probably need to be updated (can probably be done by Petr when
applying).

> +Contact:        live-patching@...r.kernel.org
> +Description:
> +		This attribute holds the stack order of a livepatch module applied
> +		to the running system.

It's probably a good idea to clarify what "stack order" means.  Also,
try to keep the text under 80 columns for consistency.

How about:

		This attribute indicates the order the patch was applied
		compared to other patches.  For example, a stack_order value of
		'2' indicates the patch was applied after the patch with stack
		order '1' and before any other currently applied patches.

-- 
Josh