linux-kernel - Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <72bafe6a2520b976ee99250dd2548a74082796b6.camel@linux.ibm.com>
Date: Tue, 01 Oct 2024 10:04:13 +0200
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Brian Cain <bcain@...cinc.com>
Cc: "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
        Arnd
 Bergmann <arnd@...nel.org>, Heiko Carstens <hca@...ux.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
 HAS_IOPORT support

On Mon, 2024-09-30 at 16:35 +0000, Brian Cain wrote:
> 
> > -----Original Message-----
> > From: Niklas Schnelle <schnelle@...ux.ibm.com>
> > Sent: Monday, September 30, 2024 10:51 AM
> > To: Brian Cain <bcain@...cinc.com>
> > Cc: linux-hexagon@...r.kernel.org; Arnd Bergmann <arnd@...nel.org>; Heiko
> > Carstens <hca@...ux.ibm.com>; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > HAS_IOPORT support
> > 
> > WARNING: This email originated from outside of Qualcomm. Please be wary of
> > any links or attachments, and do not enable macros.
> > 
> > On Wed, 2024-04-03 at 15:37 +0000, Brian Cain wrote:
> > > 
> > > > -----Original Message-----
> > > > From: Niklas Schnelle <schnelle@...ux.ibm.com>
> > > > Sent: Wednesday, April 3, 2024 10:22 AM
> > > > To: Brian Cain <bcain@...cinc.com>
> > > > Cc: linux-hexagon@...r.kernel.org; Arnd Bergmann <arnd@...nel.org>;
> > > > Heiko Carstens <hca@...ux.ibm.com>; linux-kernel@...r.kernel.org
> > > > Subject: Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > > > HAS_IOPORT support
> > > > 
> > > > WARNING: This email originated from outside of Qualcomm. Please be wary
> > > > of any links or attachments, and do not enable macros.
> > > > 
> > > > On Wed, 2024-04-03 at 14:51 +0000, Brian Cain wrote:
> > > > > 
> > > > > > -----Original Message-----
> > > > > > From: Niklas Schnelle <schnelle@...ux.ibm.com>
> > > > > > Sent: Wednesday, April 3, 2024 8:25 AM
> > > > > > To: Brian Cain <bcain@...cinc.com>
> > > > > > Cc: linux-hexagon@...r.kernel.org; Arnd Bergmann <arnd@...nel.org>;
> > > > > > Heiko Carstens <hca@...ux.ibm.com>; linux-kernel@...r.kernel.org;
> > > > Niklas
> > > > > > Schnelle <schnelle@...ux.ibm.com>
> > > > > > Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > > > > > HAS_IOPORT support
> > > > > > 
> > > > > > WARNING: This email originated from outside of Qualcomm. Please be
> > > > wary
> > > > > > of any links or attachments, and do not enable macros.
> > > > > > 
> > > > > > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> > > > > > compile time. As hexagon does not support I/O port access it also
> > > > > > the GENERIC_IOMAP mechanism of dynamically choosing between I/O
> > > > port
> > > > > > and
> > > > > > MMIO access doesn't work so don't select it.
> > > > > > 
> > > > > > Co-developed-by: Arnd Bergmann <arnd@...nel.org>
> > > > > > Signed-off-by: Arnd Bergmann <arnd@...nel.org>
> > > > > > Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> > > > > > ---
> > > > > >  arch/hexagon/Kconfig | 1 -
> > > > > >  1 file changed, 1 deletion(-)
> > > > > > 
> > > > > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > > > > > index e233b5efa276..5ea1bf4b7d4f 100644
> > > > > > --- a/arch/hexagon/Kconfig
> > > > > > +++ b/arch/hexagon/Kconfig
> > > > > > @@ -31,7 +31,6 @@ config HEXAGON
> > > > > >         select HAVE_ARCH_TRACEHOOK
> > > > > >         select NEED_SG_DMA_LENGTH
> > > > > >         select NO_IOPORT_MAP
> > > > > > -       select GENERIC_IOMAP
> > > > > >         select GENERIC_IOREMAP
> > > > > >         select GENERIC_SMP_IDLE_THREAD
> > > > > >         select STACKTRACE_SUPPORT
> > > > > 
> > > > > Reviewed-by: Brian Cain <bcain@...cinc.com>
> > > > > 
> > > > 
> > > > Thanks for the R-b, which tree should take this? If you have other
> > > > hexagon changes for v6.10 I think it would be easiest to take this
> > > > together with those. As mentioned in the cover letter the per-subsystem
> > > 
> > > I don't have other changes planned for v6.10 but I'm happy to take the
> > change in my tree.
> > > 
> > > > changes are all independent until HAS_IOPORT=n actually disables
> > > > inb()/outb() which Arnd will take once all the subsystems are covered.
> > > > 
> > > > Thanks,
> > > > Niklas
> > 
> > Hi Brian,
> > 
> > With 2 more of my HAS_IOPORT patches having gone into v6.12-rc1 I just
> > noticed that this one seems to have fallen into the cracks. This is
> > probably my fault for not properly confirming that I'd be happy for you
> > to take it. Do you want me to resend a new version rebased on v6.12-
> > rc1?
> 
> Oh, sorry!  Yes, if you could resend a rebased one I'll make sure I am able to land it.
> 
> -Brian

Hi Brian,

I just tried with

   b4 shazam '<20240403132447.719833-2-schnelle@...ux.ibm.com>'

and this patch actually still applies cleanly and matches the result I
got rebasing the whole series[0]. So on second thought taking it from
here directly might still be the easiest. That said I'll have to send
out the other 4 outstanding patches required for the final inb()
compile time switch, so if you prefer I can still resend too.

Thanks
Niklas

[0]
https://git.kernel.org/pub/scm/linux/kernel/git/niks/linux.git/log/?h=has_ioport