linux-kernel - Re: [PATCH v2] media: v4l2-subdev: Refactor events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxYCMWryQl6lZxf9@kekkonen.localdomain>
Date: Mon, 21 Oct 2024 07:26:41 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Tommaso Merciai <tomm.merciai@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Paweł Anikiel <panikiel@...gle.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: v4l2-subdev: Refactor events

Hi Laurent, Tommaso,

On Sun, Oct 20, 2024 at 07:43:54PM +0300, Laurent Pinchart wrote:
> Hi Tommaso,
> 
> Thank you for the patch.
> 
> On Sun, Oct 20, 2024 at 06:35:32PM +0200, Tommaso Merciai wrote:
> > Controls can be exposed to userspace via a v4l-subdevX device, and
> > userspace has to be able to subscribe to control events so that it is
> > notified when the control changes value.
> > If a control handler is set for the subdev then set the HAS_EVENTS
> > flag automatically into v4l2_subdev_init_finalize() and use
> > v4l2_ctrl_subdev_subscribe_event() and v4l2_event_subdev_unsubscribe()
> > as default if subdev don't have .(un)subscribe control operations.
> 
> I would add here
> 
> This simplifies subdev drivers by avoiding the need to set the
> V4L2_SUBDEV_FL_HAS_EVENTS flag and plug the event handlers, and ensures
> consistency of the API exposed to userspace.
> 
> And you can also add
> 
> Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@...il.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Thanks!

I've picked this to my tree.

Please try to properly wrap the commit message the next time, most editors
can do that automatically.

-- 
Sakari Ailus