[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241031113651.4ab4f8c7@donnerap.manchester.arm.com>
Date: Thu, 31 Oct 2024 11:36:51 +0000
From: Andre Przywara <andre.przywara@....com>
To: Cody Eksal <masterr3c0rd@...chal.quest>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
<kishon@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai
<wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland
<samuel@...lland.org>, Maxime Ripard <mripard@...nel.org>, Greg
Kroah-Hartman <gregkh@...uxfoundation.org>, Michael Turquette
<mturquette@...libre.com>, Nishanth Menon <nm@...com>, "Rafael J. Wysocki"
<rafael@...nel.org>, Stephen Boyd <sboyd@...nel.org>, Viresh Kumar
<vireshk@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>, Yangtao Li
<tiny.windzz@...il.com>, Parthiban <parthiban@...umiz.com>,
linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/13] dt-bindings: phy: sun50i-a64: add a100
compatible
On Thu, 31 Oct 2024 04:02:16 -0300
Cody Eksal <masterr3c0rd@...chal.quest> wrote:
> The USB PHY found in the A100 is similar to that found in the D1. Add a
> compatible for the A100.
>
> Signed-off-by: Cody Eksal <masterr3c0rd@...chal.quest>
Reviewed-by: Andre Przywara <andre.przywara@....com>
> Acked-by: Rob Herring (Arm) <robh@...nel.org>
Careful with that: you made quite some changes compared to v1, which Rob
ACKed, so I wouldn't carry over his tag here.
Cheers,
Andre
> ---
> Changes in V2:
> - Update binding to allow using the D1 as a compatible.
>
> .../bindings/phy/allwinner,sun50i-a64-usb-phy.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml
> index f557feca9763..21209126ed00 100644
> --- a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml
> @@ -15,9 +15,13 @@ properties:
> const: 1
>
> compatible:
> - enum:
> - - allwinner,sun20i-d1-usb-phy
> - - allwinner,sun50i-a64-usb-phy
> + oneOf:
> + - enum:
> + - allwinner,sun20i-d1-usb-phy
> + - allwinner,sun50i-a64-usb-phy
> + - items:
> + - const: allwinner,sun50i-a100-usb-phy
> + - const: allwinner,sun20i-d1-usb-phy
>
> reg:
> items:
Powered by blists - more mailing lists