linux-kernel - Re: [PATCH] arm64: dts: marvell: Drop undocumented SATA phy names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aa7f13e12646722d859ead240177eab@fw-web.de>
Date: Wed, 06 Nov 2024 22:17:24 +0100
From: "Frank Wunderlich (linux)" <linux@...web.de>
To: Rob Herring <robh@...nel.org>
Cc: Gregory CLEMENT <gregory.clement@...tlin.com>, Andrew Lunn
 <andrew@...n.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Russell King <linux@...linux.org.uk>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, frank-w@...lic-files.de
Subject: Re: [PATCH] arm64: dts: marvell: Drop undocumented SATA phy names

Am 2024-11-06 19:39, schrieb Rob Herring:
> On Wed, Nov 6, 2024 at 12:34 PM Frank Wunderlich <linux@...web.de> 
> wrote:
>> 
>> Am 5. November 2024 17:28:57 MEZ schrieb Gregory CLEMENT 
>> <gregory.clement@...tlin.com>:
>> >"Rob Herring (Arm)" <robh@...nel.org> writes:
>> >
>> >> While "phy-names" is allowed for sata-port nodes, the names used aren't
>> >> documented and are incorrect ("sata-phy" is what's documented). The name
>> >> for a single entry is fairly useless, so just drop the property.
>> >>
>> >> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
>> >
>> >Applied on mvebu/dt64
>> >
>> >Thanks,
>> >
>> >Gregory
>> >> ---
>> >> Cc: Frank Wunderlich <linux@...web.de>
>> >>
>> >> There's also this 2 year old patch fixing other SATA errors[1] which
>> >> was never picked up. :(
>> >>
>> >> [1] https://lore.kernel.org/linux-arm-kernel/20220311210357.222830-3-linux@fw-web.de/
>> 
>> Hi
>> 
>> How to deal with my patch pointed by rob?
> 
> I believe it will conflict with mine. Can you rebase on top of
> mvebu/dt64 and resend it.
> 
> Rob

i have rebased my patch [1], but it seems there are much more errors 
there (which i tried to fix there too).

To be honest marvell is confusing to me finding the right file to patch 
because of many dtsi files included by each other mixed with some 
macros.

at least some properties have to be documented in yaml:

arch/arm64/boot/dts/marvell/armada-8040-db.dtb: sata@...000: Unevaluated 
properties are not allowed ('#address-cells', '#size-cells', 
'dma-coherent', 'iommus' were unexpected)

sata-node itself seems to be defined in 
arch/arm64/boot/dts/marvell/armada-cp11x.dtsi (adress/size-cells and 
dma-coherent are defined here)

iommus seems to be added with
83a3545d9c37 2020-07-15 arm64: dts: marvell: add SMMU support Marcin 
Wojtas  (tag: mvebu-dt64-5.9-1)
which seems not be documented in txt before i converted the binding.

so something like adding this to the binding:

   '#address-cells':
     const: 1

   '#size-cells':
     const: 0

   dma-coherent: true

   iommus:
     maxItems: 1

dma-coherent was there in my version and seem to be broken with

6f997d4bb98b 2022-09-09 dt-bindings: ata: ahci-platform: Move 
dma-coherent to sata-common.yaml Serge Semin

but maybe i only get the error for it because of my call with my yaml 
only

ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make dtbs_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/ata/ahci-platform.yaml

adress/size-cells is strange to me, i'm sure i tested the yaml against 
the example which also contains them...i guess it was defined somewhere 
else.

and this one:

arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: sata@...000: 
sata-port@0:phy-names:0: 'sata-phy' was expected
	from schema $id: http://devicetree.org/schemas/ata/ahci-platform.yaml#

i guess it is taken from here:
Documentation/devicetree/bindings/ata/ahci-common.yaml:107:        
const: sata-phy

if i understand it the right way then if phy-names is defined in 
sata-subnode it has to be value "sata-phy"...so basicly somewhere in the 
chains of dtsi's a phy-name is defined to another value..am i right?

it looks like it is in 
arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi...if i drop the 
phy-names for the other sata-ports (below cp1_sata0)

seems dropping them were missing from your patch as you remove another 
one in same file (&cp0_sata0)

please correct me if i'm wrong

regards Frank

[1] https://github.com/frank-w/BPI-Router-Linux/commits/mvebu/dt64/