linux-kernel - Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7002248c-f3af-42aa-ba42-a65cd738ae37@linux.alibaba.com>
Date: Thu, 21 Nov 2024 19:34:31 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Lukas Wunner <lukas@...ner.de>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-edac@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 bhelgaas@...gle.com, tony.luck@...el.com, bp@...en8.de, rostedt@...dmis.org,
 mhiramat@...nel.org, mathieu.desnoyers@...icios.com, oleg@...hat.com,
 naveen@...nel.org, davem@...emloft.net, anil.s.keshavamurthy@...el.com,
 mark.rutland@....com, peterz@...radead.org
Subject: Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug
 event



在 2024/11/21 17:27, Lukas Wunner 写道:
> On Wed, Nov 20, 2024 at 08:43:28PM +0800, Shuai Xue wrote:
>> $ echo 1 > /sys/kernel/debug/tracing/events/hotplug/pci_hp_event/enable
>                                                ^^^^^^^
> I think this should now be "pci_hotplug" because you've renamed the
> TRACE_SYSTEM in v3.

Yes, you are right. Will fix it.

> 
> I'm wondering if we'll have other categories besides "pci_hp_event"
> below "pci_hotplug".  Maybe not.  Is it possible to omit the "pci_hotplug"
> and make "pci_hp_event" top level?  Or should this be grouped below "pci"
> instead of "pci_hotplug"?  I'm somewhat at a loss here as I'm not
> familiar with the conventions used in the tracing subsystem.

Sure, I can reorganize the directory. You have two optional proposals:

1. /sys/kernel/debug/tracing/events/pci_hp_event
2. /sys/kernel/debug/tracing/events/pci/pci_hp_event

I personally prefer the second approach. However, I'll defer the final decision
to the tracing subsystem maintainer, considering their expertise and
familiarity with the existing conventions.

> 
>  From a PCI hotplug perspective, this patch LGTM, so:
> 
> Reviewed-by: Lukas Wunner <lukas@...ner.de>


Thank you.

Best Regards,
Shuai