linux-kernel - Re: [PATCH v6 01/18] tools: Add gendwarfksyms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0YS1hVWuozpN4Ln@bombadil.infradead.org>
Date: Tue, 26 Nov 2024 10:26:30 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Sami Tolvanen <samitolvanen@...gle.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthew Maurer <mmaurer@...gle.com>,
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>,
	Petr Pavlu <petr.pavlu@...e.com>,
	Daniel Gomez <da.gomez@...sung.com>, Neal Gompa <neal@...pa.dev>,
	Hector Martin <marcan@...can.st>, Janne Grunau <j@...nau.net>,
	Miroslav Benes <mbenes@...e.cz>,
	Asahi Linux <asahi@...ts.linux.dev>,
	Sedat Dilek <sedat.dilek@...il.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v6 01/18] tools: Add gendwarfksyms

On Tue, Nov 26, 2024 at 12:50:48PM +0900, Masahiro Yamada wrote:
> On Tue, Nov 26, 2024 at 8:30 AM Luis Chamberlain <mcgrof@...nel.org> wrote:
> >
> > On Thu, Nov 21, 2024 at 08:42:22PM +0000, Sami Tolvanen wrote:
> > > Add a basic DWARF parser, which uses libdw to traverse the debugging
> > > information in an object file and looks for functions and variables.
> > > In follow-up patches, this will be expanded to produce symbol versions
> > > for CONFIG_MODVERSIONS from DWARF.
> > >
> > > Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>
> > > Reviewed-by: Petr Pavlu <petr.pavlu@...e.com>
> > > ---
> > >  kernel/module/Kconfig                 |   8 ++
> > >  scripts/Makefile                      |   1 +
> > >  scripts/gendwarfksyms/.gitignore      |   2 +
> >
> > This doesn't add scripts/gendwarfksyms to MAINTAINERS
> > but then again   scripts/genksyms/ is not there either
> > but it does got to Masahiro.
> 
> scripts/genksyms/ is a very old tool with no maintainer.
> 
> It defaults to the maintainer of the scripts/ directory (i.e. me)
> 
> > Masahiro, should we just add both to KERNEL BUILD and add
> > Sami as a Reviewer to help with gendwarfksyms?
> 
> I think it is better to have a separate entry for
> 
> F:  scripts/gendwarfksyms/
> 
> with Sami as the maintainer.

OK do you want this and the extended modversions to go through your tree
or modules tree?

  Luis