linux-kernel - Re: [PATCH v3 1/1] pps: clients: gpio: Bypass edge's direction check when not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39b78b3e-466c-4ab2-81a0-1633df48ef3e@bootlin.com>
Date: Wed, 4 Dec 2024 11:34:42 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Rodolfo Giometti <giometti@...eenne.com>
Cc: linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, herve.codina@...tlin.com,
 christophercordahi@...ometrics.ca,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 1/1] pps: clients: gpio: Bypass edge's direction check
 when not needed

Hi Rodolfo,

I revive this topic.

On 6/26/24 4:16 PM, Rodolfo Giometti wrote:
> On 26/06/24 14:55, Bastien Curutchet wrote:
>> Hi Rodolfo
>>
>> On 4/25/24 14:42, Rodolfo Giometti wrote:
>>> On 25/04/24 14:28, Bastien Curutchet wrote:
>>>> In the IRQ handler, the GPIO's state is read to verify the direction of
>>>> the edge that triggered the interruption before generating the PPS 
>>>> event.
>>>> If a pulse is too short, the GPIO line can reach back its original 
>>>> state
>>>> before this verification and the PPS event is lost.
>>>>
>>>> This check is needed when info->capture_clear is set because it needs
>>>> interruptions on both rising and falling edges. When info- 
>>>> >capture_clear
>>>> is not set, interruption is triggered by one edge only so this check 
>>>> can
>>>> be omitted.
>>>>
>>>> Add a warning if irq_handler is left without triggering any PPS event.
>>>> Bypass the edge's direction verification when info->capture_clear is 
>>>> not
>>>> set.
>>>>
>>>> Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>
>>>
>>> Acked-by: Rodolfo Giometti <giometti@...eenne.com>
>>>
>>
>> I don't think I've received any updates since you acked this. Is there 
>> something missing before the patch can be applied?
> 
> No updates. It can be applied.
> 

In the MAINTAINER file, you are listed as the sole maintainer for the 
PPS subsystem. Could you let me know if there's someone else in charge 
of applying patches so I can gently ping them please ?

I checked, the patch still applies to v6.13-rc1

Best regards,
Bastien