linux-kernel - Re: [PATCH v6 01/11] kconfig: Add PicoSAT interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1kLcQmBKC4bzm73@bombadil.infradead.org>
Date: Tue, 10 Dec 2024 19:48:01 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Ole Schuerks <ole0811sch@...il.com>
Cc: deltaone@...ian.org, jan.sollmann@....de, jude.gyimah@....de,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	masahiroy@...nel.org, nathan@...nel.org, nicolas@...sle.eu,
	thorsten.berger@....de
Subject: Re: [PATCH v6 01/11] kconfig: Add PicoSAT interface

On Mon, Dec 09, 2024 at 01:57:13AM +0100, Ole Schuerks wrote:
> Thanks for all the feedback.
> 
> > This just deals with the first error and there is no unwinding, is that OK?
> 
> This should be OK. dlsym() only retrieves the address of a symbol from an
> already loaded object. The calls to dlsym() thus should not need to be
> unwound, it's sufficient to unload the object via dlclose().

OK thanks, maybe add a comment about it.

> > Other than that, did you run this through checkpatch.pl?
> 
> I ran all patches through checkpath.pl. The only reported issues with this
> patch are the ones related to the use of the X-macro and one about the
> typedef for the PicoSAT type. 

I don't know what x-macro is so I don't have any clear opinion on that.

  Luis