linux-kernel - Re: [PATCH 2/2] usbip: Correct format specifier for seqnum from %d to %u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da4b2710-f36e-40ad-addb-6b114e60b187@linuxfoundation.org>
Date: Thu, 2 Jan 2025 15:09:27 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Xiong Nandi <xndchn@...il.com>,
 Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan
 <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "open list:USB OVER IP DRIVER" <linux-usb@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 2/2] usbip: Correct format specifier for seqnum from %d to
 %u

On 12/31/24 09:15, Xiong Nandi wrote:
> The seqnum field in USBIP protocol is an unsigned value.
> So we fix the format specifier from %d to %u to correctly
> display the value.
> 

How did you find the problem? Include log from the tool
or compiler output.

> Signed-off-by: Xiong Nandi <xndchn@...il.com>
> ---
>   drivers/usb/usbip/stub_rx.c | 2 +-
>   drivers/usb/usbip/stub_tx.c | 2 +-
>   drivers/usb/usbip/vhci_rx.c | 6 +++---
>   drivers/usb/usbip/vudc_tx.c | 2 +-
>   4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
> index 6338d818bc8b..9aa30ef76f3b 100644
> --- a/drivers/usb/usbip/stub_rx.c
> +++ b/drivers/usb/usbip/stub_rx.c
> @@ -269,7 +269,7 @@ static int stub_recv_cmd_unlink(struct stub_device *sdev,
>   		return 0;
>   	}
>   
> -	usbip_dbg_stub_rx("seqnum %d is not pending\n",
> +	usbip_dbg_stub_rx("seqnum %u is not pending\n",
>   			  pdu->u.cmd_unlink.seqnum);

seqnum is unsigned long - don't you have to use %ul?
>   
>   	/*
> diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
> index b1c2f6781cb3..7eb2e074012a 100644
> --- a/drivers/usb/usbip/stub_tx.c
> +++ b/drivers/usb/usbip/stub_tx.c
> @@ -201,7 +201,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
>   
>   		/* 1. setup usbip_header */
>   		setup_ret_submit_pdu(&pdu_header, urb);
> -		usbip_dbg_stub_tx("setup txdata seqnum: %d\n",
> +		usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
>   				  pdu_header.base.seqnum);
>   
>   		if (priv->sgl) {
> diff --git a/drivers/usb/usbip/vhci_rx.c b/drivers/usb/usbip/vhci_rx.c
> index 7f2d1c241559..a75f4a898a41 100644
> --- a/drivers/usb/usbip/vhci_rx.c
> +++ b/drivers/usb/usbip/vhci_rx.c
> @@ -66,7 +66,7 @@ static void vhci_recv_ret_submit(struct vhci_device *vdev,
>   	spin_unlock_irqrestore(&vdev->priv_lock, flags);
>   
>   	if (!urb) {
> -		pr_err("cannot find a urb of seqnum %u max seqnum %d\n",
> +		pr_err("cannot find a urb of seqnum %u max seqnum %u\n",
>   			pdu->base.seqnum,
>   			atomic_read(&vhci_hcd->seqnum));
>   		usbip_event_add(ud, VDEV_EVENT_ERROR_TCP);
> @@ -162,10 +162,10 @@ static void vhci_recv_ret_unlink(struct vhci_device *vdev,
>   		 * already received the result of its submit result and gave
>   		 * back the URB.
>   		 */
> -		pr_info("the urb (seqnum %d) was already given back\n",
> +		pr_info("the urb (seqnum %u) was already given back\n",
>   			pdu->base.seqnum);
>   	} else {
> -		usbip_dbg_vhci_rx("now giveback urb %d\n", pdu->base.seqnum);
> +		usbip_dbg_vhci_rx("now giveback urb %u\n", pdu->base.seqnum);
>   
>   		/* If unlink is successful, status is -ECONNRESET */
>   		urb->status = pdu->u.ret_unlink.status;
> diff --git a/drivers/usb/usbip/vudc_tx.c b/drivers/usb/usbip/vudc_tx.c
> index 3ccb17c3e840..30c11bf9f4e7 100644
> --- a/drivers/usb/usbip/vudc_tx.c
> +++ b/drivers/usb/usbip/vudc_tx.c
> @@ -107,7 +107,7 @@ static int v_send_ret_submit(struct vudc *udc, struct urbp *urb_p)
>   
>   	/* 1. setup usbip_header */
>   	setup_ret_submit_pdu(&pdu_header, urb_p);
> -	usbip_dbg_stub_tx("setup txdata seqnum: %d\n",
> +	usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
>   			  pdu_header.base.seqnum);
>   	usbip_header_correct_endian(&pdu_header, 1);
>   
thanks,
-- Shuah