linux-kernel - Re: [PATCH v2 01/28] module: Extend the preempt disabled section in dereference_symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <kknhqunwsiumn2dkdhnc43ecuzdvqa7zws553gnocnksz5vl36@jllfly2mjegz>
Date: Tue, 7 Jan 2025 19:58:43 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Daniel Gomez <da.gomez@...sung.com>, Luis Chamberlain <mcgrof@...nel.org>, 
	"Paul E . McKenney" <paulmck@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Petr Pavlu <petr.pavlu@...e.com>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Thomas Gleixner <tglx@...utronix.de>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	Christophe Leroy <christophe.leroy@...roup.eu>, Helge Deller <deller@....de>, 
	Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, 
	Naveen N Rao <naveen@...nel.org>, Nicholas Piggin <npiggin@...il.com>, 
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 01/28] module: Extend the preempt disabled section in
 dereference_symbol_descriptor().

On (24/12/20 18:41), Sebastian Andrzej Siewior wrote:
> dereference_symbol_descriptor() needs to obtain the module pointer
> belonging to pointer in order to resolve that pointer.
> The returned mod pointer is obtained under RCU-sched/ preempt_disable()
> guarantees and needs to be used within this section to ensure that the
> module is not removed in the meantime.
> 
> Extend the preempt_disable() section to also cover
> dereference_module_function_descriptor().
> 
> Fixes: 04b8eb7a4ccd9 ("symbol lookup: introduce dereference_symbol_descriptor()")
> Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Helge Deller <deller@....de>
> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Naveen N Rao <naveen@...nel.org>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> Cc: linux-parisc@...r.kernel.org
> Cc: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

FWIW
Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>