linux-kernel - Re: [PATCH v5 5/5] PCI: altera: Add Agilex support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <793b4cf1-bdf4-4010-aece-79c720ed05ad@kernel.org>
Date: Wed, 29 Jan 2025 10:50:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthew Gerlach <matthew.gerlach@...ux.intel.com>, lpieralisi@...nel.org,
 kw@...ux.com, manivannan.sadhasivam@...aro.org, robh@...nel.org,
 bhelgaas@...gle.com, krzk+dt@...nel.org, conor+dt@...nel.org,
 dinguyen@...nel.org, joyce.ooi@...el.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: matthew.gerlach@...era.com, peter.colberg@...era.com,
 "D M, Sharath Kumar" <sharath.kumar.d.m@...el.com>
Subject: Re: [PATCH v5 5/5] PCI: altera: Add Agilex support

On 27/01/2025 18:35, Matthew Gerlach wrote:
> +
>  static const struct of_device_id altera_pcie_of_match[] = {
>  	{.compatible = "altr,pcie-root-port-1.0",
>  	 .data = &altera_pcie_1_0_data },
>  	{.compatible = "altr,pcie-root-port-2.0",
>  	 .data = &altera_pcie_2_0_data },
> +	{.compatible = "altr,pcie-root-port-3.0-f-tile",
> +	 .data = &altera_pcie_3_0_f_tile_data },
> +	{.compatible = "altr,pcie-root-port-3.0-p-tile",
> +	 .data = &altera_pcie_3_0_p_tile_data },
> +	{.compatible = "altr,pcie-root-port-3.0-r-tile",
> +	 .data = &altera_pcie_3_0_r_tile_data },

Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also `scripts/checkpatch.pl --strict` and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.

Best regards,
Krzysztof