linux-kernel - Re: [PATCH v6 1/1] MIPS: Fix idle VS timer enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAofZF50P0+c6QbNxzEunwbDGUZEZpKM8wa2dBYXAVFFYGq-hA@mail.gmail.com>
Date: Fri, 21 Mar 2025 11:44:10 +0100
From: Marco Crivellari <marco.crivellari@...e.com>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Frederic Weisbecker <frederic@...nel.org>, linux-mips@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Anna-Maria Behnsen <anna-maria@...utronix.de>, 
	Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, 
	Huacai Chen <chenhuacai@...nel.org>, "Maciej W . Rozycki" <macro@...am.me.uk>
Subject: Re: [PATCH v6 1/1] MIPS: Fix idle VS timer enqueue

On Fri, Mar 21, 2025 at 10:38 AM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
> do we really need that for a symbol local to that file ?

Not really, I can use the label directly.

On Fri, Mar 21, 2025 at 10:38 AM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
>
> > +       /* Check idle interrupt region size. */
> > +       .ifne   __r4k_wait_exit - __r4k_wait - 36
>
> I have to say, that I prefer my .if statement, since this clearly spells out
> the comparision in the expression. Is there a reason for your version ?

Sure, let's keep your version.
Can we use the "error" message above? (""Idle interrupt region size
mismatch: expected 36 bytes."").
Or at least something similar, I think it is easier to understand the
reason for the error. What do you think?

Thanks!

-- 

Marco Crivellari

L3 Support Engineer, Technology & Product




marco.crivellari@...e.com