linux-kernel - Re: [PATCH 11/15] dt-bindings: pinctrl: renesas: Document RZ/V2N SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d88eee6-1401-4ffc-85bb-3ea91f28d186@kernel.org>
Date: Thu, 27 Mar 2025 08:48:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prabhakar <prabhakar.csengg@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Magnus Damm <magnus.damm@...il.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mmc@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Biju Das <biju.das.jz@...renesas.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 11/15] dt-bindings: pinctrl: renesas: Document RZ/V2N SoC

On 26/03/2025 15:39, Prabhakar wrote:
> +#define RZV2N_P3	3
> +#define RZV2N_P4	4
> +#define RZV2N_P5	5
> +#define RZV2N_P6	6
> +#define RZV2N_P7	7
> +#define RZV2N_P8	8
> +#define RZV2N_P9	9
> +#define RZV2N_PA	10
> +#define RZV2N_PB	11

Same comments as before - not useful to repeat the name.

It is the third patch in this patchset, which receives exactly the same
comments as given before.

I expect that given feedback somehow stays within group of contributions
or company in form of internal knowledge. Or just read other people's
patchset to learn from them and do not make the same mistakes.

> +
> +#define RZV2N_PORT_PINMUX(b, p, f)	RZG2L_PORT_PINMUX(RZV2N_P##b, p, f)
> +#define RZV2N_GPIO(port, pin)		RZG2L_GPIO(RZV2N_P##port, pin)

Not a binding. If you claim otherwise, point me to the line of driver
code using this binding.

Best regards,
Krzysztof