linux-kernel - Re: [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ucxebkad5fov7vejtenikor4zfujuggqwbzzmnvm7yj6rw4hfn@ibpcbnf5oscj>
Date: Thu, 3 Apr 2025 14:43:08 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: shao.mingyin@....com.cn
Cc: andersson@...nel.org, linus.walleij@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, yang.yang29@....com.cn,
        xu.xin16@....com.cn, ye.xingchen@....com.cn, xie.ludan@....com.cn
Subject: Re: [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname

On Thu, Apr 03, 2025 at 03:50:14PM +0800, shao.mingyin@....com.cn wrote:
> From: Xie Ludan <xie.ludan@....com.cn>
> 
> Introduce devm_platform_ioremap_resource_byname() to simplify
> resource retrieval and mapping.This new function consolidates
> platform_get_resource_byname() and devm_ioremap_resource() into a single
> call, improving code readability and reducing API call overhead.

Commit message is incorrect. You are not introducing anything, you are
removing a whitespace.

> 
> Signed-off-by: Xie Ludan <xie.ludan@....com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
> ---
>  drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 13cdd6c0fbd7..264ac0e7152d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1548,7 +1548,7 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> 
>  	if (soc_data->tiles) {
>  		for (i = 0; i < soc_data->ntiles; i++) {
> -			pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev, 
> +			pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
>  																   soc_data->tiles[i]);
>  			if (IS_ERR(pctrl->regs[i]))
>  				return PTR_ERR(pctrl->regs[i]);
> -- 
> 2.25.1

-- 
With best wishes
Dmitry