linux-kernel - Re: [PATCH 3/8] staging: sm750fb: rename vendorID to vendor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025041819-kimono-wife-1f30@gregkh>
Date: Fri, 18 Apr 2025 12:37:37 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ruben Wauters <rubenru09@....com>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Teddy Wang <teddy.wang@...iconmotion.com>,
	Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] staging: sm750fb: rename vendorID to vendor_id

On Thu, Apr 17, 2025 at 08:02:51PM +0100, Ruben Wauters wrote:
> Fixes camel case check reported by checkpatch.pl
> 
> Signed-off-by: Ruben Wauters <rubenru09@....com>
> ---
>  drivers/staging/sm750fb/ddk750_sii164.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index d4309e0d807f..9f660a9be5d6 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -26,14 +26,14 @@ static char *dvi_controller_chip_name = "Silicon Image SiI 164";
>   */
>  unsigned short sii164_get_vendor_id(void)
>  {
> -	unsigned short vendorID;
> +	unsigned short vendor_id;
>  
> -	vendorID = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS,
> +	vendor_id = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS,
>  							  SII164_VENDOR_ID_HIGH) << 8) |
> -		   (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS,
> -							 SII164_VENDOR_ID_LOW);
> +		    (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS,
> +							  SII164_VENDOR_ID_LOW);
>  
> -	return vendorID;
> +	return vendor_id;

Why is the temporary variable needed at all?  Why not just return the
value directly?

thanks,

greg k-h