[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025041831-tricky-gag-de34@gregkh>
Date: Fri, 18 Apr 2025 12:38:59 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ruben Wauters <rubenru09@....com>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Teddy Wang <teddy.wang@...iconmotion.com>,
Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] staging: sm750fb: rename hotPlugValue to
hot_plug_value
On Thu, Apr 17, 2025 at 08:02:56PM +0100, Ruben Wauters wrote:
> Renames hotPlugValue to hot_plug_value
>
> fixes checkpatch.pl's camel case check.
>
> Signed-off-by: Ruben Wauters <rubenru09@....com>
> ---
> drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 769cbe768c49..86490c87156a 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -344,11 +344,11 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug)
> */
> unsigned char sii164_is_connected(void)
This should be returning a boolean, right? Not your fault, just noticed
it for further potential cleanups if you want to do that.
thanks,
greg k-h
Powered by blists - more mailing lists