linux-kernel - Re: [PATCH] ufs: core: add caps UFSHCD_CAP_MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250422062555.694-1-tanghuan@vivo.com>
Date: Tue, 22 Apr 2025 14:25:55 +0800
From: Huan Tang <tanghuan@...o.com>
To: peter.wang@...iatek.com
Cc: James.Bottomley@...senPartnership.com,
	alim.akhtar@...sung.com,
	avri.altman@....com,
	bvanassche@....org,
	ebiggers@...gle.com,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com,
	minwoo.im@...sung.com,
	opensource.kernel@...o.com,
	quic_nguyenb@...cinc.com,
	tanghuan@...o.com
Subject: Re: [PATCH] ufs: core: add caps UFSHCD_CAP_MCQ_EN

> This patch of only add a flag and always enables this flag. 
> In other words, it is a meaningless patch.
> Suggest also uptream the flow of the disable flag patch 
> as part of a patch series.

Hi Peter sir,

Thanks for you reply!
I found that using low-end UFS in SoCs that support MCQ may cause
device latency to reach extreme values.

My idea is that after having this patch, I can add hba->caps &=
~UFSHCD_CAP_MCQ_EN to disable mcq via ufs-qcom.c or ufs-mediatek.c. 

Do you mean to add a caps UFSHCD_CAP_MCQ_DISABLE? 
Or remove hba->caps |= UFSHCD_CAP_MCQ_EN in ufshcd_alloc_host, 
and then add hba->caps |= UFSHCD_CAP_MCQ_EN in ufs-xxx.c, such as ufs-mediatek.c?

Thanks
Huan