linux-kernel - RE: [PATCH v7 06/13] clk: renesas: Add support for R9A09G077 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11492F29C81C6A33A9ED90F888ABA2@TYCPR01MB11492.jpnprd01.prod.outlook.com>
Date: Wed, 23 Apr 2025 07:36:45 +0000
From: Thierry Bultel <thierry.bultel.yh@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: "thierry.bultel@...atsea.fr" <thierry.bultel@...atsea.fr>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, Paul
 Barker <paul.barker.ct@...renesas.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>
Subject: RE: [PATCH v7 06/13] clk: renesas: Add support for R9A09G077 SoC



> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: mercredi 23 avril 2025 09:19
> To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> Cc: thierry.bultel@...atsea.fr; linux-renesas-soc@...r.kernel.org; Paul
> Barker <paul.barker.ct@...renesas.com>; linux-kernel@...r.kernel.org;
> linux-clk@...r.kernel.org
> Subject: Re: [PATCH v7 06/13] clk: renesas: Add support for R9A09G077 SoC
> 
> Hi Thierry,


Hi Geert,
> 
> On Fri, 18 Apr 2025 at 23:22, Thierry Bultel
> <thierry.bultel.yh@...renesas.com> wrote:
>  > +};
> > > > +
> > > > +static const struct mssr_mod_clk r9a09g077_mod_clks[] __initconst =
> {
> > > > +       DEF_MOD("sci0", 108, R9A09G077_PCLKM),
> > >
> > > Shouldn't that be 8 instead of 108?
> > > Using R9A09G077_PCLKM as the parent is a temporary simplification,
> right?
> >
> > I am probably missing something, isn’t PCKML actually the parent clock ?
> 
> According to Figure 7.1 ("Block diagram of clock generation circuit"), it
> is PCLKSCI0, which can be switched to PCLKM.  I guess that is the default,
> hence my "temporary simplification" question.
> 
> As the actual switching is controlled through the SCI's CCR3 register, the
> SCI block should have two clock inputs in DT (PCLKM and PCLKSCIn), and
> thus the DT bindings should be amended.  See also Figure 33.1 ("SCI block
> diagram").
> 

Thanks for clarifying.
Indeed, this is the default setting (and the one we have at this stage).
I think that support for PCLKSCIn can be added at the time we support
baudrate setting.

Thierry

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds