linux-kernel - Re: [PATCH v1 08/10] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for Exyno5250 smdk5250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a1e2432-46e2-40f6-84af-bff45ab79899@kernel.org>
Date: Fri, 25 Apr 2025 16:48:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Anand Moon <linux.amoon@...il.com>, Chanwoo Choi <cw00.choi@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 "open list:MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BO..."
 <linux-kernel@...r.kernel.org>,
 "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES"
 <linux-arm-kernel@...ts.infradead.org>,
 "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES"
 <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v1 08/10] ARM: dts: exynos: Add proper regulator states
 for suspend-to-mem for Exyno5250 smdk5250

On 25/04/2025 15:26, Anand Moon wrote:
> The MAX77686 PMCI is able to power down and up key core supplies and other
> voltage rails via PWRREQ signal to enter / exit (deep) sleep mode.
> PWRREQ status is ignored during initial power up and down processes.
> All programming must be done before the AP enterns the sleep mode by
> pulling PWRREQ low since the AP does not have programming capability
> in (deep) sleep mode.
> 
> Add suspend-to-mem node to regulator core to be enabled or disabled
> during system suspend and also support changing the regulator operating
> mode during runtime and when the system enter sleep mode (stand by mode).
> 
> Regulators which can be turned off during system suspend:
> 	-LDOn   :       2, 6-8, 10-12, 14-16,
>         -BUCKn  :       1-4.
> Use standard regulator bindings for it ('regulator-off-in-suspend').

I do not believe you tested this but instead send whatever you found
somewhere without actually understanding the code. In the past you were
sending such patches - without knowing what they do and without actually
testing.

NAK

Best regards,
Krzysztof