lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b39f9d2b-17d0-4619-b676-f476d17ffb6b@oss.qualcomm.com>
Date: Wed, 30 Apr 2025 12:35:49 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Abel Vesa <abel.vesa@...aro.org>, Sebastian Reichel <sre@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Xilin Wu <wuxilin123@...il.com>,
        Jens Glathe <jens.glathe@...schoolsolutions.biz>,
        Srinivas Kandagatla <srini@...nel.org>,
        Johan Hovold <johan+linaro@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Konrad Dybcio <quic_kdybcio@...cinc.com>
Subject: Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3
 compatible override

On 4/30/25 11:39 AM, Abel Vesa wrote:
> On 25-04-30 01:26:13, Sebastian Reichel wrote:
>> Hi,
>>
>> On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
>>> It all started with the support for CRD back when we had different
>>> compatibles for eDP and DP. Meanwhile, that has been sorted out and it
>>> is now figured out at runtime while using only the DP compatible.
>>>
>>> It's almost funny how this got copied over from CRD and spread to all
>>> X Elite platforms.
>>>
>>> TBH, the best reason to drop it ASAP is to make sure this doesn't spread
>>> beyond X Elite to newer platforms.
>>>
>>> Functionally nothing changes.
>>
>> Looking at the diff I wonder if this part should also be simplified:
>>
>> /delete-property/ #sound-dai-cells;
>>
>> This is done by all upstream X1E boards, so maybe just drop the
>> #sound-dai-cells directly in x1e80100.dtsi?
> 
> Yeah, I'm not sure about that.
> 
> Though the DP3 PHY is currently used as eDP, I think it could be used
> as DP. So I think it makes more sense to keep the DP3 controller as is
> in the SoC dtsi and delete the #sound-dai-cells property in each board
> specific dts. Don't know if it will ever be the case with this SoC, but
> maybe someone will use DP3 with the PHY configured as DP rather than
> eDP.
> 
> Not sure if I'm 100% right about this though.
> 
> Dmitry, Bjorn, do you think that is accurate enough?

I'd say just keep it everywhere, the physical capability of the
controller to send audio streams is there, but is left unused by
the specific eDP usecase (which is determined dynamically)

Konrad

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ