linux-kernel - Re: [PATCH v4 06/18] clk: qcom: common: Add support to configure clk regs in qcom_cc_really

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25bcfc38-8753-4d7b-a530-a7d0dd69e488@quicinc.com>
Date: Wed, 21 May 2025 15:13:28 +0530
From: Jagadeesh Kona <quic_jkona@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Dmitry Baryshkov <lumag@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Taniya Das <quic_tdas@...cinc.com>,
        "Satya Priya
 Kakitapalli" <quic_skakitap@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 06/18] clk: qcom: common: Add support to configure clk
 regs in qcom_cc_really_probe



On 5/15/2025 12:04 PM, Bryan O'Donoghue wrote:
> On 14/05/2025 20:08, Jagadeesh Kona wrote:
>> +        if (!pll->config || !pll->regs) {
>> +            pr_err("%s: missing pll config or regs\n", init->name);
>> +            continue;
>> +        }
> 
> If you are printing error, why aren't you returning error ?
> 
> I understand that it probably makes platform bringup easier if we print instead of error here.
> 
> I think this should be a failure case with a -EINVAL or some other indicator you prefer.
> 
> Assuming you amend to return an error you may add my
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>


Sure, will check and return error in case of failure in next series

Thanks,
Jagadeesh