linux-kernel - Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f361faffc1863358e8fda98f994f6a49b6f0d4c9.camel@HansenPartnership.com>
Date: Tue, 27 May 2025 07:28:59 -0400
From: James Bottomley <James.Bottomley@...senPartnership.com>
To: Alexey Gladkov <legion@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>, 
	Luis Chamberlain
	 <mcgrof@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>, Daniel Gomez
	 <da.gomez@...sung.com>, Masahiro Yamada <masahiroy@...nel.org>, Nathan
	Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas.schier@...ux.dev>
Cc: linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org, 
 linux-kbuild@...r.kernel.org, Khalid Aziz <khalid@...ehiking.org>, "Martin
 K. Petersen" <martin.petersen@...cle.com>, linux-scsi
 <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if
 necessary

On Tue, 2025-05-27 at 11:07 +0200, Alexey Gladkov wrote:
> Define MODULE_DEVICE_TABLE only if a structure is defined for it.
> 
> drivers/scsi/BusLogic.c:3735:26: error: use of undeclared identifier
> 'blogic_pci_tbl'
>  3735 | MODULE_DEVICE_TABLE(pci, blogic_pci_tbl);

Well, a) need to cc the scsi list and b) how is this possible when
MODULE_DEVICE_TABLE() has an empty definition if MODULE isn't defined
(so the guard you move should be over an empty statement)?

Regards,

James