linux-kernel - Re: [PATCH 7/8] KVM: s390: Stop adding virt/kvm to the arch include path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d794e153-3442-45b0-9913-13967859ff7d@linux.ibm.com>
Date: Thu, 12 Jun 2025 15:01:08 +0200
From: Janosch Frank <frankja@...ux.ibm.com>
To: Sean Christopherson <seanjc@...gle.com>, Marc Zyngier <maz@...nel.org>,
        Oliver Upton <oliver.upton@...ux.dev>,
        Tianrui Zhao
 <zhaotianrui@...ngson.cn>,
        Bibo Mao <maobibo@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Anup Patel <anup@...infault.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt
 <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
        kvm@...r.kernel.org, loongarch@...ts.linux.dev,
        linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        kvm-riscv@...ts.infradead.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Anish Ghulati <aghulati@...gle.com>,
        Colton Lewis <coltonlewis@...gle.com>, Thomas Huth <thuth@...hat.com>
Subject: Re: [PATCH 7/8] KVM: s390: Stop adding virt/kvm to the arch include
 path

On 6/11/25 2:10 AM, Sean Christopherson wrote:
> Don't add virt/kvm to KVM s390's include path, the headers in virt/kvm are
> intended to be used only by other code in virt/kvm, i.e. are "private" to
> the core KVM code.  It's not clear that s390 *ever* included a header from
> virt/kvm, i.e. odds are good the "-Ivirt/kvm" was copied from a x86's
> Makefile when s390 support was first added.
> 
> The only headers in virt/kvm at the time were the x86 specific ioapic.h,
> and iodev.h, neither of which shows up as an #include in the diff for the
> commit range 37817f2982d0f..e976a2b997fc4.
> 
> Acked-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@...hat.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>