linux-kernel - Re: [PATCH 0/2] media: uvcvideo: Enable keep-sorted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08a426ae-be6e-4cbc-aaaf-7197bf839632@jjverkuil.nl>
Date: Tue, 17 Jun 2025 13:52:50 +0200
From: Hans Verkuil <hans@...erkuil.nl>
To: Hans de Goede <hansg@...nel.org>, Ricardo Ribalda <ribalda@...omium.org>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] media: uvcvideo: Enable keep-sorted

On 16/06/2025 15:38, Hans de Goede wrote:
> Hi Ricardo,
> 
> On 16-Jun-25 15:31, Ricardo Ribalda wrote:
>> On Mon, 16 Jun 2025 at 15:26, Hans de Goede <hansg@...nel.org> wrote:
>>>
>>> Hi Ricardo,
>>>
>>> On 16-Jun-25 15:22, Ricardo Ribalda wrote:
>>>> Hi Hans
>>>>
>>>> On Mon, 16 Jun 2025 at 15:05, Hans de Goede <hansg@...nel.org> wrote:
>>>>>
>>>>> Hi Ricardo,
>>>>>
>>>>> On 29-Apr-25 15:47, Ricardo Ribalda wrote:
>>>>>> When committers contribute quirks to the uvc driver, they usually add
>>>>>> them out of order.
>>>>>>
>>>>>> We can automatically validate that their follow our guidelines with the
>>>>>> use of keep-sorted.
>>>>>>
>>>>>> This patchset adds support for keep-sorted in the uvc driver. The two
>>>>>> patches can be squashed if needed.
>>>>>>
>>>>>> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
>>>>>
>>>>> I've no objections against these 2 patches, but these need to be
>>>>> rebased on top of the latest uvc/for-next. Can you send out a new
>>>>> version please ?
>>>>
>>>> I was waiting for HansV to say that keep-sorted was useful and then
>>>> add it to the CI.
>>>
>>> Ok, so should we drop this series from patchwork then ?
>>
>> If the series does not bother you too much in patchwork let it stay
>> there until HansV replies to the makefile series.

I did that. Basically I don't like the keep-sorted annotation unless it
is rolled out kernel-wide. It's not something we should do just in the
media subsystem.

That doesn't mean that a patch fixing the uvc_ids order isn't welcome,
but just drop the annotation.

If we do that, then patch 1/2 is also no longer needed. Although it
feels more logical that match_flags is at the end. I leave that to
HdG and Laurent to decide.

Regards,

	Hans

> 
> Sure that works for me.
> 
> Regards,
> 
> Hans
> 
>