linux-kernel - Re: [PATCH v1] perf test: Add basic callgraph test to record testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFW94vQb9cbO4-V0@google.com>
Date: Fri, 20 Jun 2025 13:00:34 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: James Clark <james.clark@...aro.org>
Cc: Ian Rogers <irogers@...gle.com>, Thomas Richter <tmricht@...ux.ibm.com>,
	Dapeng Mi <dapeng1.mi@...ux.intel.com>,
	Chun-Tse Shao <ctshao@...gle.com>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v1] perf test: Add basic callgraph test to record testing

On Thu, Jun 19, 2025 at 09:24:04AM +0100, James Clark wrote:
> 
> 
> On 19/06/2025 1:24 am, Ian Rogers wrote:
> > Give some basic perf record callgraph coverage.
> > 
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
> >   tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index 2022a4f739be..603fa6b79b5d 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
> >   . "${shelldir}"/lib/perf_has_symbol.sh
> >   testsym="test_loop"
> > +testsym2="brstack"
> >   skip_test_missing_symbol ${testsym}
> > +skip_test_missing_symbol ${testsym2}
> >   err=0
> >   perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> > @@ -359,6 +361,23 @@ test_precise_max() {
> >     fi
> >   }
> > +test_callgraph() {
> > +  echo "Callgraph test"
> > +  if ! perf record -o "${perfdata}" -g perf test -w brstack
> 
> Looking at 2dac1f089 ("perf test: Fix 'perf script' tests on s390"), it
> looks like this won't work there. Although I'm not sure why the fix wasn't
> to change the default -g mode to dwarf on s390 if fp doesn't work at all.
> That wouldn't fix -e cpu-clock being required though.

Maybe we can add a new 'perf check callchain' subcommand to check the
relevant information and display and/or verify them properly.

Thanks,
Namhyung