linux-kernel - Re: [PATCH 4/5] arm64: dts: allwinner: a523: Add UART1 pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250620145508.4d483885@donnerap.manchester.arm.com>
Date: Fri, 20 Jun 2025 14:55:08 +0100
From: Andre Przywara <andre.przywara@....com>
To: Chen-Yu Tsai <wens@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej
 Skrabec <jernej@...nel.org>, Samuel Holland <samuel@...lland.org>,
 devicetree@...r.kernel.org, linux-sunxi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] arm64: dts: allwinner: a523: Add UART1 pins

On Fri, 20 Jun 2025 01:30:06 +0800
Chen-Yu Tsai <wens@...nel.org> wrote:

> From: Chen-Yu Tsai <wens@...e.org>
> 
> UART1 is normally used to connect to the Bluetooth side of a Broadcom
> WiFi+BT combo chip. The connection uses 4 pins.
> 
> Add pinmux nodes for UART1, one for the RX/TX pins, and one for the
> RTS/CTS pins.

Interestingly there is only one possible set of pins for UART1, so the
naming is correct. Which would also mean we can insert the pinctrl-0
property in the UART DT node in the .dtsi file already.
Regardless, checked against the manual:

> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 30613a0b1124..6f62201fd739 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -168,6 +168,20 @@ uart0_pb_pins: uart0-pb-pins {
>  				allwinner,pinmux = <2>;
>  				function = "uart0";
>  			};
> +
> +			/omit-if-no-ref/
> +			uart1_pins: uart1-pins {
> +				pins = "PG6", "PG7";
> +				function = "uart1";
> +				allwinner,pinmux = <2>;
> +			};
> +
> +			/omit-if-no-ref/
> +			uart1_rts_cts_pins: uart1-rts-cts-pins {
> +				pins = "PG8", "PG9";
> +				function = "uart1";
> +				allwinner,pinmux = <2>;
> +			};
>  		};
>  
>  		ccu: clock-controller@...1000 {