linux-kernel - 回覆: [PATCH 7/7] pci: aspeed: Add ASPEED PCIe host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134003D5FA55835C9A5537E9D7BA@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Wed, 25 Jun 2025 08:32:13 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>, "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
	"mani@...nel.org" <mani@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "joel@....id.au" <joel@....id.au>,
	"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "kishon@...nel.org"
	<kishon@...nel.org>, "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, LKML <linux-kernel@...r.kernel.org>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	"openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"elbadrym@...gle.com" <elbadrym@...gle.com>, "romlem@...gle.com"
	<romlem@...gle.com>, "anhphan@...gle.com" <anhphan@...gle.com>,
	"wak@...gle.com" <wak@...gle.com>, "yuxiaozhang@...gle.com"
	<yuxiaozhang@...gle.com>, BMC-SW <BMC-SW@...eedtech.com>
Subject:
 回覆: [PATCH 7/7] pci: aspeed: Add ASPEED PCIe host controller driver

> > > > +/* TLP configuration type 0 and type 1 */
> > > > +#define CRG_READ_FMTTYPE(type)		(0x04000000 | (type << 24))
> > > > +#define CRG_WRITE_FMTTYPE(type)		(0x44000000 | (type << 24))
> > >
> > > These are straight from PCIe spec, right?
> > >
> > > I think those should come from defines inside
> > > include/uapi/linux/pci_regs.h, there might not be one already, so
> > > you might have to add them.
> > >
> > > I also think you should actually use the type as boolean, and return
> > > one of the two defines based on it. A helper to do that might be
> > > generic PCI header material as well.
> > >
> >
> > Agreed.  This definition is used on TLP header.  Maybe I will try to
> > add some definitions to pci_regs.h or pci.h
> 
> This values might come from the PCIe spec, but unless they are needed outside
> drivers/pci, any #defines should probably go in drivers/pci/pci.h.

Got it. I will sperate some definitions that are from PCIe spec to drivers/pci/pci.h
In next version.
These values are like the content of TLP header format. I will define them in 
drivers/pci/pci.h.

Thanks,
Jacky