linux-kernel - Re: [PATCH] binder: Add missing module description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJo6IeEPEJpqjUlu@google.com>
Date: Mon, 11 Aug 2025 18:44:49 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Salvatore Bonaccorso <carnil@...ian.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <christian@...uner.io>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Ben Hutchings <benh@...ian.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binder: Add missing module description

On Mon, Aug 11, 2025 at 08:01:05PM +0200, Salvatore Bonaccorso wrote:
> Hi,
> 
> On Mon, Aug 11, 2025 at 05:36:20PM +0000, Carlos Llamas wrote:
> > On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> > > During build modpost issues a warning:
> > > 
> > >     # MODPOST Module.symvers
> > >        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
> > >     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> > > 
> > > Fix this by adding the missing module description.
> > 
> > I'm not against having a description but binder is not tristate. Judging
> > from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
> > I'm not sure you would be able to reproduce the warn.
> 
> This is entirely my fault. We saw the warning while building in
> Debian, but missed that we apply the following patch:
> https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
> which allows to build binder as module.
> 
> I got confused by the fact that we have 
> MODULE_LICENSE("GPL v2");
> in the upstream variant, but no description.
> 
> So you want to still have the description added or drop this proposed
> patch completely instead?

I think it is best to drop all MODULE_* macros and avoid further
confusion. Including the current MODULE_LICENSE(), this is misleading.
I'll send a patch fixing this.

However, I don't see why we couldn't take all those patches to support
binder tristate later on. Assuming that other maintainers would be ok
exporting all those symbols used by binder that is. We are not using
binder as a module but it doesn't hurt either. wdyt?

--
Carlos Llamas