linux-kernel - Re: [PATCH] selftests/bpf: Fix typo in kprobe_multi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN3jmPQ2HfxVoFg_Jpif3EbjAtdii1hrnRzvC58skTBu=+ZGbA@mail.gmail.com>
Date: Thu, 14 Aug 2025 17:59:02 +0530
From: Shubham Sharma <slopixelz@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, 
	martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org, 
	yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org, 
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, mykolal@...com, 
	shuah@...nel.org, bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c

On Thu, Aug 14, 2025 at 3:35 AM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Tue, Aug 12, 2025 at 8:37 AM Shubham Sharma <slopixelz@...il.com> wrote:
> >
> > Fixed a spelling mistake:
> > - comparision -> comparison
> >
> > Signed-off-by: Shubham Sharma <slopixelz@...il.com>
> > ---
> >  tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > index e19ef509ebf8..f377bea0b82d 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > @@ -463,7 +463,7 @@ static bool skip_entry(char *name)
> >         return false;
> >  }
> >
> > -/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
> > +/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
>
> Is this the only typo in the entire BPF selftests? If we are doing
> single character comment fixes, let's do it as one bigger pass,
> instead of tons of tiny patches?
>
> pw-bot: cr
>
>
> >  static int compare_name(const char *name1, const char *name2)
> >  {
> >         const char *res1, *res2;
> > --
> > 2.43.0
> >


Thank you for the feedback. I understand that small, single-character
fixes are better grouped into a larger patch to avoid multiple tiny
commits.
I’ll review the BPF selftests code for similar typos and send a
combined patch instead.

Thanks,
Shubham Sharma