linux-kernel - Re: [PATCH 1/2] dt-bindings: mips: lantiq: Document Lantiq Xway GPTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250814-settling-hamstring-d6a6e957f6c6@spud>
Date: Thu, 14 Aug 2025 21:50:37 +0100
From: Conor Dooley <conor@...nel.org>
To: Aleksander Jan Bajkowski <olek2@...pl>
Cc: tsbogend@...ha.franken.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-mips@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mips: lantiq: Document Lantiq Xway GPTU

On Thu, Aug 14, 2025 at 11:36:59AM +0200, Aleksander Jan Bajkowski wrote:
> The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
> ---
>  .../mips/lantiq/lantiq,gptu-xway.yaml         | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml b/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> new file mode 100644
> index 000000000000..fcfc634dd391
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,gptu-xway.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq Xway SoC series General Purpose Timer Unit (GPTU)

"SoC series" implies that you're using the same compatible for multiple
devices. Why are you not using device-specific compatibles?

> +
> +maintainers:
> +  - Aleksander Jan Bajkowski <olek2@...pl>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - lantiq,gptu-xway
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 6
> +    maxItems: 6

And these interrupts are what exactly? I'd rather an items list
explaining what they are tbh.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    gptu@...0a00 {
> +        compatible = "lantiq,gptu-xway";
> +        reg = <0xe100a00 0x100>;
> +        interrupt-parent = <&icu0>;
> +        interrupts = <126>, <127>, <128>, <129> ,<130>, <131>;
> +    };
> -- 
> 2.47.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)