[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <44585871-aabe-4d6d-b4c9-17d9acaa8063@freeshell.de>
Date: Sun, 24 Aug 2025 12:48:21 -0700
From: E Shattow <e@...eshell.de>
To: Icenowy Zheng <uwu@...nowy.me>, Hal Feng <hal.feng@...rfivetech.com>,
Conor Dooley <conor+dt@...nel.org>,
Emil Renner Berthing <emil.renner.berthing@...onical.com>,
Heinrich Schuchardt <heinrich.schuchardt@...onical.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley
<paul.walmsley@...ive.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/3] dt-bindings: riscv: Add StarFive JH7110S SoC and
VisionFive 2 Lite board
On 8/24/25 10:14, Icenowy Zheng wrote:
> 在 2025-08-21星期四的 18:09 +0800,Hal Feng写道:
>> Add device tree bindings for the StarFive JH7110S SoC
>> and the VisionFive 2 Lite board equipped with it.
>>
>> JH7110S SoC is an industrial SoC which can run at -40~85 degrees
>> centigrade
>> and up to 1.25GHz. Its CPU cores and peripherals are mostly similar
>> to
>> those of the JH7110 SoC.
>>
>> Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
>> ---
>> Documentation/devicetree/bindings/riscv/starfive.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml
>> b/Documentation/devicetree/bindings/riscv/starfive.yaml
>> index 7ef85174353d..a2952490709f 100644
>> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
>> @@ -33,6 +33,11 @@ properties:
>> - starfive,visionfive-2-v1.3b
>> - const: starfive,jh7110
>>
>> + - items:
>> + - enum:
>> + - starfive,visionfive-2-lite
>> + - const: starfive,jh7110s
>
> I suggest adding starfive,jh7110 as a fallback here, as it's the SoC
> best known to most softwares, and JH7110S shouldn't have any difference
> to JH7110 other than binning.
>
>> +
>> additionalProperties: true
>>
>> ...
>
NAK, it is said the operating parameters of jh7110s are distinct from
jh7110. You would have to show that it is safe to operate the jh7110s
with the operating parameters of the jh7110. If anything this would be
the inverse, some jh711x (or even j71xx to include jh7100) common
description with fallback operating parameters? And to add this common
fallback with jh7100 (?), jh7110, jh7110s -E
Powered by blists - more mailing lists