linux-kernel - RE: [PATCH v11 19/24] crypto: iaa - IAA acomp_algs register the get_batch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB81219B313D6C18AE26AB06A7C93AA@PH7PR11MB8121.namprd11.prod.outlook.com>
Date: Fri, 29 Aug 2025 03:12:10 +0000
From: "Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
To: Barry Song <21cnbao@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "hannes@...xchg.org"
	<hannes@...xchg.org>, "yosry.ahmed@...ux.dev" <yosry.ahmed@...ux.dev>,
	"nphamcs@...il.com" <nphamcs@...il.com>, "chengming.zhou@...ux.dev"
	<chengming.zhou@...ux.dev>, "usamaarif642@...il.com"
	<usamaarif642@...il.com>, "ryan.roberts@....com" <ryan.roberts@....com>,
	"ying.huang@...ux.alibaba.com" <ying.huang@...ux.alibaba.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"senozhatsky@...omium.org" <senozhatsky@...omium.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
	"davem@...emloft.net" <davem@...emloft.net>, "clabbe@...libre.com"
	<clabbe@...libre.com>, "ardb@...nel.org" <ardb@...nel.org>,
	"ebiggers@...gle.com" <ebiggers@...gle.com>, "surenb@...gle.com"
	<surenb@...gle.com>, "Accardi, Kristen C" <kristen.c.accardi@...el.com>,
	"Gomes, Vinicius" <vinicius.gomes@...el.com>, "Feghali, Wajdi K"
	<wajdi.k.feghali@...el.com>, "Gopal, Vinodh" <vinodh.gopal@...el.com>,
	"Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
Subject: RE: [PATCH v11 19/24] crypto: iaa - IAA acomp_algs register the
 get_batch_size() interface.


> -----Original Message-----
> From: Barry Song <21cnbao@...il.com>
> Sent: Thursday, August 28, 2025 5:17 PM
> To: Sridhar, Kanchana P <kanchana.p.sridhar@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-mm@...ck.org;
> hannes@...xchg.org; yosry.ahmed@...ux.dev; nphamcs@...il.com;
> chengming.zhou@...ux.dev; usamaarif642@...il.com;
> ryan.roberts@....com; ying.huang@...ux.alibaba.com; akpm@...ux-
> foundation.org; senozhatsky@...omium.org; linux-crypto@...r.kernel.org;
> herbert@...dor.apana.org.au; davem@...emloft.net;
> clabbe@...libre.com; ardb@...nel.org; ebiggers@...gle.com;
> surenb@...gle.com; Accardi, Kristen C <kristen.c.accardi@...el.com>;
> Gomes, Vinicius <vinicius.gomes@...el.com>; Feghali, Wajdi K
> <wajdi.k.feghali@...el.com>; Gopal, Vinodh <vinodh.gopal@...el.com>
> Subject: Re: [PATCH v11 19/24] crypto: iaa - IAA acomp_algs register the
> get_batch_size() interface.
> 
> On Fri, Aug 1, 2025 at 4:36 PM Kanchana P Sridhar
> <kanchana.p.sridhar@...el.com> wrote:
> >
> > The Fixed ("deflate-iaa") and Dynamic ("deflate-iaa-dynamic") IAA
> > acomp_algs register an implementation for get_batch_size(). zswap can
> > query crypto_acomp_batch_size() to get the maximum number of requests
> > that can be batch [de]compressed. zswap can use the minimum of this, and
> > any zswap-specific upper limits for batch-size to allocate batching
> > resources.
> >
> > This enables zswap to compress/decompress pages in parallel in the IAA
> > hardware accelerator to improve swapout/swapin performance and
> memory
> > savings.
> >
> > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
> > ---
> >  drivers/crypto/intel/iaa/iaa_crypto_main.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> > index 480e12c1d77a5..b7c6fc334dae7 100644
> > --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> > +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> > @@ -2785,6 +2785,7 @@ static struct acomp_alg iaa_acomp_fixed_deflate
> = {
> >         .init                   = iaa_comp_init_fixed,
> >         .compress               = iaa_comp_acompress_main,
> >         .decompress             = iaa_comp_adecompress_main,
> > +       .get_batch_size         = iaa_comp_get_max_batch_size,
> >         .base                   = {
> >                 .cra_name               = "deflate",
> >                 .cra_driver_name        = "deflate-iaa",
> > @@ -2810,6 +2811,7 @@ static struct acomp_alg
> iaa_acomp_dynamic_deflate = {
> >         .init                   = iaa_comp_init_dynamic,
> >         .compress               = iaa_comp_acompress_main,
> >         .decompress             = iaa_comp_adecompress_main,
> > +       .get_batch_size         = iaa_comp_get_max_batch_size,
> 
> I feel the patches are being split too finely and are not fully
> self-contained. You added iaa_comp_get_max_batch_size in the previous
> patch, but the callback appears in this one. Why not combine them
> together? Anyway, since you are moving to a static field, this patch
> will be removed automatically.

Yes, based on your earlier suggestion I have made the note to bundle
related patches :)

Thanks,
Kanchana