linux-kernel - Re: [PATCH v5 2/3] dt-bindings: pinctrl: qcom: Add SDM660 LPI pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23267241-e3ac-4475-a828-fb581133e475@kernel.org>
Date: Wed, 3 Sep 2025 16:14:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nickolay Goppen <setotau@...nlining.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, linux@...nlining.org,
 Nickolay Goppen <setotau@...dex.ru>, Richard Acayan <mailingradian@...il.com>
Subject: Re: [PATCH v5 2/3] dt-bindings: pinctrl: qcom: Add SDM660 LPI pinctrl

On 03/09/2025 15:39, Nickolay Goppen wrote:
> +
> +examples:
> +  - |
> +    lpi_tlmm: pinctrl@...70000 {
> +        compatible = "qcom,sdm660-lpass-lpi-pinctrl";
> +        reg = <0x15070000 0x20000>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +        gpio-ranges = <&lpi_tlmm 0 0 32>;
> +
> +        cdc_pdm_default: cdc-pdm-default-state {
> +                clk-pins {

Messed indentation. Keep four spaces.

> +                    pins = "gpio18";
> +                    function = "pdm_clk";
> +                    drive-strength = <8>;
> +                    output-high;
> +                };
> +
> +                sync-pins{
> +                    pins = "gpio19";
> +                    function = "pdm_sync";
> +                    drive-strength = <4>;
> +                    output-high;
> +                };
> +
> +                tx-pins {
> +                    pins = "gpio20";
> +                    function = "pdm_tx";
> +                    drive-strength = <8>;
> +                };
> +
> +                rx-pins {
> +                    pins = "gpio21", "gpio23", "gpio25";
> +                    function = "pdm_rx";
> +                    drive-strength = <4>;
> +                    output-high;
> +                };
> +        };
> +
> +        cdc_comp_default: cdc-comp-default-state {
> +                pins = "gpio22", "gpio24";

Also here.

With these fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof