linux-kernel - Re: [PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fc5a9fe-3459-4303-a6c4-5cf51d2e49a6@gmail.com>
Date: Thu, 4 Sep 2025 19:23:56 +0900
From: Akira Yokosawa <akiyks@...il.com>
To: akito5623@...il.com
Cc: akiyks@...il.com, corbet@....net, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

Hello Kurita-san,

On Wed,  3 Sep 2025 20:35:04 +0900, kurita <akito5623@...il.com> wrote:
> The Japanese translation of SubmittingPatches is based on an old
> kernel version (2.6.39) and is missing several new sections.
> 
> This patch adds the missing description for the 'Fixes:' tag to
> bring the document more in line with the current English original
> (Documentation/process/submitting-patches.rst).

Assuming this is the first patch you submitted, I'd like to show you
some background.

In 2022, I did some catch-up work for SubmittingPatches in the hopes
of working with another Japanese-speaker.  Unfortunately, I gave up after
he had moved on to other activities.

howto.rst had a couple of updates worked on at the time.

Please see commits:

    6548e96edb50 ("docs/trans/ja_JP/howto: Don't mention specific kernel versions")
    dc8ab0298028 ("docs/ja_JP/howto: Update for v6.1")

, and/or email threads in the lore archive:

    https://lore.kernel.org/20220501102256.6379-1-fujimotokosuke0@gmail.com/
    https://lore.kernel.org/20221030115209.25924-1-akiyks@gmail.com/

If you think it is worthwhile to spend your time in updating the translation,
please feel free to do so.  I'd be glad to play a reviewer's role.

Comments on this particular patch follow (for your future contributions):

> 
> Signed-off-by:Akiyoshi kurita <akito5623@...il.com>

Malformed "Signed-off-by".

Also, please set up your Git config so that git-send-email uses
a proper From: field.

This mail has:

    From: kurita <akito5623@...il.com>

, which does not match your sign off.

Both of them would have been pointed out by ./scripts/checkpatch.pl.

> ---
>  Documentation/translations/ja_JP/SubmittingPatches | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/translations/ja_JP/SubmittingPatches b/Documentation/translations/ja_JP/SubmittingPatches
> index 5334db471744..053468a20841 100644
> --- a/Documentation/translations/ja_JP/SubmittingPatches
> +++ b/Documentation/translations/ja_JP/SubmittingPatches
> @@ -465,6 +465,10 @@ Suggested-by: タグは、パッチのアイデアがその人からの提案に
>  クレジットしていけば、望むらくはその人たちが将来別の機会に再度力を貸す気に
>  なってくれるかもしれません。
>  
> +パッチが特定のコミットのバグを修正するものである場合、
> +（例えば、``git bisect`` を使用して問題を発見した場合など）、
> +SHA-1 ID の最初の 12 文字以上と 1 行の要約を含む「Fixes:」タグを使用してください。
> +

This doesn't look like the right position in the translation.

I see it comes from commit 8401aa1f5997 ("Documentation/SubmittingPatches:
describe the Fixes: tag"). Quoting relevant hunk below:

> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 2a8e89e13e45..7e9abb8a276b 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -132,6 +132,20 @@ Example:
>         platform_set_drvdata(), but left the variable "dev" unused,
>         delete it.
>  
> +If your patch fixes a bug in a specific commit, e.g. you found an issue using
> +git-bisect, please use the 'Fixes:' tag with the first 12 characters of the
> +SHA-1 ID, and the one line summary.
> +Example:
> +
> +       Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
> +
> +The following git-config settings can be used to add a pretty format for
> +outputting the above style in the git log or git show commands
> +
> +       [core]
> +               abbrev = 12
> +       [pretty]
> +               fixes = Fixes: %h (\"%s\")

If you'd like to pursue this route, I'd like you to cover all the changes
made in the commit and mention it in the changelog.

Thanks,
Akira