linux-kernel - Re: [PATCH net-next 10/10] net/mlx5e: Use the 'num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250910102345.4fd2b49f@kernel.org>
Date: Wed, 10 Sep 2025 10:23:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Jiri Pirko <jiri@...nulli.us>, Jonathan Corbet
 <corbet@....net>, "Leon Romanovsky" <leon@...nel.org>, Jason Gunthorpe
 <jgg@...pe.ca>, Saeed Mahameed <saeedm@...dia.com>, Mark Bloch
 <mbloch@...dia.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, "John
 Fastabend" <john.fastabend@...il.com>, <netdev@...r.kernel.org>,
 <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, <bpf@...r.kernel.org>, Gal Pressman
 <gal@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>, Dragos Tatulea
 <dtatulea@...dia.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 10/10] net/mlx5e: Use the 'num_doorbells'
 devlink param

On Wed, 10 Sep 2025 13:24:51 +0300 Tariq Toukan wrote:
> @@ -45,6 +45,14 @@ Parameters
>       - The range is between 1 and a device-specific max.
>       - Applies to each physical function (PF) independently, if the device
>         supports it. Otherwise, it applies symmetrically to all PFs.
> +   * - ``num_doorbells``
> +     - driverinit
> +     - This controls the number of channel doorbells used by the netdev. In all
> +       cases, an additional doorbell is allocated and used for non-channel
> +       communication (e.g. for PTP, HWS, etc.). Supported values are:
> +       - 0: No channel-specific doorbells, use the global one for everything.
> +       - [1, max_num_channels]: Spread netdev channels equally across these
> +         doorbells.

This is not vibing with the changes we merged yesterday (or I fumbled
the merge):

Documentation/networking/devlink/mlx5.rst:13: ERROR: Error parsing content block for the "list-table" directive: uniform two-level bullet list expected, but row 8 does not contain the same number of items as row 1 (3 vs 4).

Also in this series:

drivers/net/ethernet/mellanox/mlx5/core/devlink.c:549:11-83: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD