linux-kernel - Re: [PATCH] pid: use ns_capable_noaudit() when determining net sysctl permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23663be0b8dc2a435bcc46a3d52e9e19@paul-moore.com>
Date: Thu, 11 Sep 2025 16:46:20 -0400
From: Paul Moore <paul@...l-moore.com>
To: Christian Göttsche <cgoettsche@...tendoof.de>, linux-kernel@...r.kernel.org
Cc: Christian Göttsche <cgzones@...glemail.com>, Christian Brauner <brauner@...nel.org>, linux-security-module@...r.kernel.org, selinux@...r.kernel.org
Subject: Re: [PATCH] pid: use ns_capable_noaudit() when determining net sysctl  permissions

On Sep 10, 2025 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgoettsche@...tendoof.de> wrote:
> 
> The capability check should not be audited since it is only being used
> to determine the inode permissions. A failed check does not indicate a
> violation of security policy but, when an LSM is enabled, a denial audit
> message was being generated.
> 
> The denial audit message can either lead to the capability being
> unnecessarily allowed in a security policy, or being silenced potentially
> masking a legitimate capability check at a later point in time.
> 
> Similar to commit d6169b0206db ("net: Use ns_capable_noaudit() when
> determining net sysctl permissions")
> 
> Fixes: 7863dcc72d0f ("pid: allow pid_max to be set per pid namespace")
> CC: Christian Brauner <brauner@...nel.org>
> CC: linux-security-module@...r.kernel.org
> CC: selinux@...r.kernel.org
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
>  kernel/pid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Paul Moore <paul@...l-moore.com>

--
paul-moore.com