linux-kernel - Re: [PATCH v6 10/11] gpu: nova-core: Add base files for r570.144 firmware bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DCUAYNNP97QI.1VOX5XUS9KP7K@kernel.org>
Date: Tue, 16 Sep 2025 16:42:56 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Alexandre Courbot" <acourbot@...dia.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
 <jhubbard@...dia.com>, "Alistair Popple" <apopple@...dia.com>, "Joel
 Fernandes" <joelagnelf@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <nouveau@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v6 10/11] gpu: nova-core: Add base files for r570.144
 firmware bindings

Two comments on this, just for the record.

On Sat Sep 13, 2025 at 4:12 PM CEST, Alexandre Courbot wrote:
> From: Alistair Popple <apopple@...dia.com>
>
> Interacting with the GSP currently requires using definitions from C
> header files. Rust definitions for the types needed for Nova core will
> be generated using the Rust bindgen tool. This patch adds the base
> module to allow inclusion of the generated bindings. The generated
> bindings themselves are added by subsequent patches when they are first
> used.

For now this is perfectly fine, but in the long term we should avoid creating
bindings from C headers. Instead, I'd like to see the tooling that generates the
C headers to generate the Rust data structures (in a more Rust idiomatic way)
right away.

> Currently we only intend to support a single firmware version, 570.144,
> with these bindings. Longer term we intend to move to a more stable GSP
> interface that isn't tied to specific firmware versions.

Yet, we have to prepare for proper abstraction of the firmware API:

(1) This is a community project. And as a community project it has to be
    written in a way that is guaranteed to remain maintainable for the
    community in any case.

    This means that the project can not rely on the hardware vendor to provide
    a stable firmware API; rather it has to written in a way that can deal with
    changing conditions.

    In fact, this is one of the issues why we don't see a way forward with
    nouveau, so we can't lock ourselves in here. :)

(2) While I think attempting to be as stable as possible with the firmware API
    is the correct approach, I also think it is better to reserve yourself some
    flexibility on changing it.

    I much rather prefer a firmware API that is evolving when really necessary,
    than squeezing new features into an existing API (e.g. by adding confusing
    extentions) that just isn't a good fit anymore at some point.

> Signed-off-by: Alistair Popple <apopple@...dia.com>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> [acourbot@...dia.com: adapt the bindings module comment a bit]
> Acked-by: Danilo Krummrich <dakr@...nel.org>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>