linux-kernel - Re: [PATCH v4 2/3] sched: make migrate_enable/migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250916110712.GI3245006@noisy.programming.kicks-ass.net>
Date: Tue, 16 Sep 2025 13:07:12 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Menglong Dong <menglong.dong@...ux.dev>
Cc: ast@...nel.org, mingo@...hat.com, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, daniel@...earbox.net, john.fastabend@...il.com,
	andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com,
	song@...nel.org, yonghong.song@...ux.dev, kpsingh@...nel.org,
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org,
	tzimmermann@...e.de, simona.vetter@...ll.ch, jani.nikula@...el.com,
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline

On Thu, Aug 28, 2025 at 02:03:53PM +0800, Menglong Dong wrote:

> +/* The "struct rq" is not available here, so we can't access the
> + * "runqueues" with this_cpu_ptr(), as the compilation will fail in
> + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr():
> + *   typeof((ptr) + 0)
> + *
> + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here.
> + */

Please fix broken comment style while you fix that compile error.