[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <373bbb78-2b0c-446c-be97-53b82edeed64@quicinc.com>
Date: Tue, 16 Sep 2025 16:37:02 +0530
From: Nihal Kumar Gupta <quic_nihalkum@...cinc.com>
To: Rob Herring <robh@...nel.org>, Vikram Sharma <quic_vikramsa@...cinc.com>
CC: <vladimir.zapolskiy@...aro.org>, <bryan.odonoghue@...aro.org>,
<mchehab@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<andersson@...nel.org>, <konradybcio@...nel.org>,
<hverkuil-cisco@...all.nl>, <cros-qcom-dts-watchers@...omium.org>,
<catalin.marinas@....com>, <will@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>, <quic_svankada@...cinc.com>,
<linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Ravi Shankar <quic_rshankar@...cinc.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: qcom-cci: Document qcs8300
compatible
On 16-09-2025 08:18, Rob Herring wrote:
> On Fri, Sep 12, 2025 at 07:41:32PM +0530, Vikram Sharma wrote:
>> From: Nihal Kumar Gupta <quic_nihalkum@...cinc.com>
>>
>> Add device tree bindings for the CCI controller on the
>> Qualcomm QCS8300 SoC.
>> Introduce the "qcom,qcs8300-cci" compatible string.
> Wrap commit messages at 72 chars. And explain how it's the same or
> different from existing SoCs in the commit message. Don't explain the
> diff. We can read that ourselves.
>
SA8775P(Lemans) has 4 CCIs, while QCS8300 (Monaco) has 3 CCI, with the
only difference being the GPIOs used for SDA/SCL pins.
Currently, the CCI driver probe happens through the "qcom,msm8996-cci"
compatible string. Could we use the existing SA8775P compatible string
"qcom,sa8775p-cci" or we should remove it?
Please advise on the preferred approach for upstream compliance.
>> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@...cinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
>> Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
Regards,
Nihal Kumar Gupta
Powered by blists - more mailing lists