linux-kernel - Re: [PATCH 2/2] pmdomain: thead: create auxiliary device for rebooting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89ed15328b73b191fe152cf8559b92239b5596bd.camel@icenowy.me>
Date: Thu, 18 Sep 2025 23:44:02 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Drew Fustini <fustini@...nel.org>, Guo Ren <guoren@...nel.org>, Fu Wei
 <wefu@...hat.com>, Michal Wilczynski <m.wilczynski@...sung.com>, Sebastian
 Reichel <sre@...nel.org>, Han Gao <rabenda.cn@...il.com>, Yao Zi
 <ziyao@...root.org>,  linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org,  linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] pmdomain: thead: create auxiliary device for
 rebooting

在 2025-09-04星期四的 12:14 +0200，Ulf Hansson写道：
> On Mon, 18 Aug 2025 at 09:49, Icenowy Zheng <uwu@...nowy.me> wrote:
> > 
> > The reboot / power off operations require communication with the
> > AON
> > firmware too.
> > 
> > As the driver is already present, create an auxiliary device with
> > name
> > "reboot" to match that driver, and pass the AON channel by using
> > platform_data.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> > ---
> >  drivers/pmdomain/thead/th1520-pm-domains.c | 35
> > ++++++++++++++++++++--
> >  1 file changed, 33 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pmdomain/thead/th1520-pm-domains.c
> > b/drivers/pmdomain/thead/th1520-pm-domains.c
> > index 9040b698e7f7f..8285f552897b0 100644
> > --- a/drivers/pmdomain/thead/th1520-pm-domains.c
> > +++ b/drivers/pmdomain/thead/th1520-pm-domains.c
> > @@ -129,12 +129,39 @@ static void th1520_pd_init_all_off(struct
> > generic_pm_domain **domains,
> >         }
> >  }
> > 
> > -static void th1520_pd_pwrseq_unregister_adev(void *adev)
> > +static void th1520_pd_unregister_adev(void *adev)
> >  {
> >         auxiliary_device_delete(adev);
> >         auxiliary_device_uninit(adev);
> >  }
> > 
> > +static int th1520_pd_reboot_init(struct device *dev, struct
> > th1520_aon_chan *aon_chan)
> > +{
> > +       struct auxiliary_device *adev;
> > +       int ret;
> > +
> > +       adev = devm_kzalloc(dev, sizeof(*adev), GFP_KERNEL);
> > +       if (!adev)
> > +               return -ENOMEM;
> > +
> > +       adev->name = "reboot";
> > +       adev->dev.parent = dev;
> > +       adev->dev.platform_data = aon_chan;
> > +
> > +       ret = auxiliary_device_init(adev);
> > +       if (ret)
> > +               return ret;
> > +
> > +       ret = auxiliary_device_add(adev);
> > +       if (ret) {
> > +               auxiliary_device_uninit(adev);
> > +               return ret;
> > +       }
> > +
> > +       return devm_add_action_or_reset(dev,
> > th1520_pd_unregister_adev,
> > +                                       adev);
> 
> We have devm_auxiliary_device_create() now, I suggest we use that
> instead.

Should I send a v2 to convert to use this?

> 
> That said, I think it would make sense to convert the pwrseq-gpu
> auxiliary device to be registered with devm_auxiliary_device_create()
> too, but that's a separate change, of course.
> 
> > +}
> > +
> >  static int th1520_pd_pwrseq_gpu_init(struct device *dev)
> >  {
> >         struct auxiliary_device *adev;
> > @@ -169,7 +196,7 @@ static int th1520_pd_pwrseq_gpu_init(struct
> > device *dev)
> >                 return ret;
> >         }
> > 
> > -       return devm_add_action_or_reset(dev,
> > th1520_pd_pwrseq_unregister_adev,
> > +       return devm_add_action_or_reset(dev,
> > th1520_pd_unregister_adev,
> >                                         adev);
> >  }
> > 
> > @@ -235,6 +262,10 @@ static int th1520_pd_probe(struct
> > platform_device *pdev)
> >         if (ret)
> >                 goto err_clean_provider;
> > 
> > +       ret = th1520_pd_reboot_init(dev, aon_chan);
> > +       if (ret)
> > +               goto err_clean_provider;
> > +
> >         return 0;
> > 
> >  err_clean_provider:
> > --
> > 2.50.1
> > 
> 
> Otherwise this looks good to me!
> 
> Kind regards
> Uffe