linux-kernel - Re: [PATCH v7 0/3] PCI: imx6: Add external reference clock mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <o3pajmedldkgpmqrnnnoz5nrbx6dz7vnodlpuc6tivbxvln6lf@nxuvdtqoixdx>
Date: Sat, 20 Sep 2025 13:08:54 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Richard Zhu <hongxing.zhu@....com>
Cc: frank.li@....com, l.stach@...gutronix.de, lpieralisi@...nel.org, 
	kwilczynski@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	bhelgaas@...gle.com, shawnguo@...nel.org, s.hauer@...gutronix.de, 
	kernel@...gutronix.de, festevam@...il.com, linux-pci@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/3] PCI: imx6: Add external reference clock mode
 support

On Thu, Sep 18, 2025 at 11:25:52AM +0800, Richard Zhu wrote:
> i.MX95 PCIes have two reference clock inputs: one from internal PLL, the
> other from off chip crystal oscillator. The "extref" clock refers to a
> reference clock from an external crystal oscillator.
> 
> Add external reference clock input mode support for i.MX95 PCIes.
> 

Driver change looks good to me (except a nitpick that I reported, but I could
fix it while applying), but the binding patches need to be reviewed by the DT
binding maintainers.

- Mani

> Main change in v7:
> - Refine the subjects and commit message refer to Bjorn's comments.
> 
> Main change in v6:
> - Refer to Krzysztof's comments, let i.MX95 PCIes has the "ref" clock
>   since it is wired actually, and add one more optional "extref" clock
>   for i.MX95 PCIes.
> https://lore.kernel.org/imx/20250917045238.1048484-1-hongxing.zhu@nxp.com/
> 
> Main change in v5:
> - Update the commit message of first patch refer to Bejorn's comments.
> - Correct the typo error and update the description of property in the
>   first patch.
> https://lore.kernel.org/imx/20250915035348.3252353-1-hongxing.zhu@nxp.com/
> 
> Main change in v4:
> - Add one more reference clock "extref" to be onhalf the reference clock
>   that comes from external crystal oscillator.
> https://lore.kernel.org/imx/20250626073804.3113757-1-hongxing.zhu@nxp.com/
> 
> Main change in v3:
> - Update the logic check external reference clock mode is enabled or
>   not in the driver codes.
> https://lore.kernel.org/imx/20250620031350.674442-1-hongxing.zhu@nxp.com/
> 
> Main change in v2:
> - Fix yamllint warning.
> - Refine the driver codes.
> https://lore.kernel.org/imx/20250619091004.338419-1-hongxing.zhu@nxp.com/
> 
> [PATCH v7 1/3] dt-bindings: PCI: dwc: Add external reference clock
> [PATCH v7 2/3] dt-bindings: PCI: pci-imx6: Add external reference
> [PATCH v7 3/3] PCI: imx6: Add external reference clock input mode
> 
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml      |  3 +++
> Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml |  6 ++++++
> drivers/pci/controller/dwc/pci-imx6.c                          | 20 +++++++++++++-------
> 3 files changed, 22 insertions(+), 7 deletions(-)
> 

-- 
மணிவண்ணன் சதாசிவம்