linux-kernel - Re: [PATCH] vmalloc: Update __vmalloc_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO4qtMe8iMdcs0EV@MiWiFi-R3L-srv>
Date: Tue, 14 Oct 2025 18:49:24 +0800
From: Baoquan He <bhe@...hat.com>
To: "Uladzislau Rezki (Sony)" <urezki@...il.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vmalloc: Update __vmalloc_node_noprof() documentation

On 10/13/25 at 07:42pm, Uladzislau Rezki (Sony) wrote:
> The kernel-doc for the __vmalloc_node_noprof() incorrectly states
> that __GFP_NOFAIL reclaim modifier is not supported. In fact it has
> been supported since commit 9376130c390a ("mm/vmalloc: add support
> for __GFP_NOFAIL").
> 
> To avoid duplication and future drift, point this helper's doc to
> __vmalloc_node_range_noprof() for details and the full description.
> 
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> ---
>  mm/vmalloc.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Reviewed-by: Baoquan He <bhe@...hat.com>

> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 9a63c91c6150..c31fa69cc530 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4027,11 +4027,8 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align,
>   * Allocate enough pages to cover @size from the page level allocator with
>   * @gfp_mask flags.  Map them into contiguous kernel virtual space.
>   *
> - * Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_RETRY_MAYFAIL
> - * and __GFP_NOFAIL are not supported
> - *
> - * Any use of gfp flags outside of GFP_KERNEL should be consulted
> - * with mm people.
> + * Semantics of @gfp_mask(including reclaim/retry modifiers such as
> + * __GFP_NOFAIL) are the same as in __vmalloc_node_range_noprof().
>   *
>   * Return: pointer to the allocated memory or %NULL on error
>   */
> -- 
> 2.47.3
>