linux-kernel - Re: [PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add generic dwxgmac compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6a34c11-4ec8-4b96-ad61-642a4be3eef6@kernel.org>
Date: Sun, 26 Oct 2025 09:53:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Steffen Trumtrar <s.trumtrar@...gutronix.de>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Matthew Gerlach <matthew.gerlach@...era.com>
Cc: kernel@...gutronix.de, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add
 generic dwxgmac compatible

On 24/10/2025 13:49, Steffen Trumtrar wrote:
> Add the more generic "snps,dwxgmac" compatible to the list of
> compatibles for the agilex5.
> 
> The snps,dwmac binding explicitly uses the "snps,dwxgmac-2.10",

Hm? No, binding says only dwxgmac-2.10, DTS only dwxgmac-2.10.

> "snps,dwxgmac" combination as example; the stmmac driver only checks on

Example does not matter.

> dwmac and dwxgmac compatibles to decide what kind of gmac it is working

Huh? I clearly see snps,dwxgmac-2.10 in dwmac-generic.c

> with.
This change really lacks proper rationale.

Best regards,
Krzysztof