linux-kernel - Re: [PATCH v2] crypto: qat - use simple_strtoull to improve qat_uclo_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQNwHuNwPy6rDz-1@smile.fi.intel.com>
Date: Thu, 30 Oct 2025 16:03:10 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Jack Xu <jack.xu@...el.com>,
	Suman Kumar Chakraborty <suman.kumar.chakraborty@...el.com>,
	Qianfeng Rong <rongqianfeng@...o.com>, qat-linux@...el.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] crypto: qat - use simple_strtoull to improve
 qat_uclo_parse_num

On Thu, Oct 30, 2025 at 11:27:37AM +0000, Giovanni Cabiddu wrote:
> On Mon, Oct 27, 2025 at 11:02:16AM +0200, Andy Shevchenko wrote:
> > On Sun, Oct 26, 2025 at 02:57:07AM +0100, Thorsten Blum wrote:
> > > Replace the manual string copying and parsing logic with a call to
> > > simple_strtoull() to simplify and improve qat_uclo_parse_num().
> > > 
> > > Ensure that the parsed number does not exceed UINT_MAX, and add an
> > > approximate upper-bound check (no more than 19 digits) to guard against
> > > overflow.
> > 
> > Reviewed-by; Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> s/;/:
> 
> I just noticed this while applying the patch to my local tree.
> 
> Due to the typo, patchwork is not applying your tag [1].

Oh, thanks for catching this. Have you added it manually or should I do
something about it?

> [1] https://patchwork.kernel.org/project/linux-crypto/patch/20251026015710.1368-1-thorsten.blum@linux.dev/mbox/

-- 
With Best Regards,
Andy Shevchenko