linux-kernel - RE: [PATCH 2/4] remoteproc: imx_rproc: Add runtime ops copy to support dynamic behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB84596BBD914686B0F0B4DC3288FBA@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Thu, 30 Oct 2025 11:12:33 +0000
From: Peng Fan <peng.fan@....com>
To: Daniel Baluta <daniel.baluta@...il.com>
CC: Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier
	<mathieu.poirier@...aro.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	Daniel Baluta <daniel.baluta@....com>, Frank Li <frank.li@....com>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/4] remoteproc: imx_rproc: Add runtime ops copy to
 support dynamic behavior

Hi Daniel,

> Subject: Re: [PATCH 2/4] remoteproc: imx_rproc: Add runtime ops
> copy to support dynamic behavior
> 
> Hi Peng,
> 
> One comment.
> 
> 
> > @@ -116,6 +116,7 @@ struct imx_rproc {
> >         u32                             entry;          /* cpu start address */
> >         u32                             core_index;
> >         struct dev_pm_domain_list       *pd_list;
> > +       struct imx_rproc_plat_ops       ops;
> >  };
> 
> Here do you plan to change a member of the ops table at runtime?
> Like e.g replace just the start ops? Or the entire table.
> 
> Because it would be better to add something like this:

Need to change start/stop/prepare, no need change detect_mode.
But it should be ok to change to const pointer per your suggestion.

I will follow this in next version.

Thanks,
Peng.

> 
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -116,7 +116,7 @@ struct imx_rproc {
>         u32                             entry;          /* cpu start address */
>         u32                             core_index;
>         struct dev_pm_domain_list       *pd_list;
> -       struct imx_rproc_plat_ops       ops;
> +       const struct imx_rproc_plat_ops       *ops;
>  };