linux-kernel - Re: [PATCH net v1 1/2] page_pool: expose max page pool ring size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a07e27f-69de-4a38-884a-5ad078e7acf5@kernel.org>
Date: Wed, 5 Nov 2025 22:56:31 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Joshua Washington <joshwash@...gle.com>,
 Harshitha Ramamurthy <hramamurthy@...gle.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Simon Horman <horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v1 1/2] page_pool: expose max page pool ring size

On 05/11/2025 21.07, Mina Almasry wrote:
> Expose this as a constant so we can reuse it in drivers.
> 
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> ---
>   include/net/page_pool/types.h | 2 ++
>   net/core/page_pool.c          | 2 +-
>   2 files changed, 3 insertions(+), 1 deletion(-)

Looks good to me

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
> index 1509a536cb85..5edba3122b10 100644
> --- a/include/net/page_pool/types.h
> +++ b/include/net/page_pool/types.h
> @@ -58,6 +58,8 @@ struct pp_alloc_cache {
>   	netmem_ref cache[PP_ALLOC_CACHE_SIZE];
>   };
>   
> +#define PAGE_POOL_MAX_RING_SIZE 16384
> +

IIRC this was recently reduced to 16384 (from 32K), do you have a
use-case for higher limits?

>   /**
>    * struct page_pool_params - page pool parameters
>    * @fast:	params accessed frequently on hotpath
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 1a5edec485f1..7b2808da294f 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -211,7 +211,7 @@ static int page_pool_init(struct page_pool *pool,
>   		return -EINVAL;
>   
>   	if (pool->p.pool_size)
> -		ring_qsize = min(pool->p.pool_size, 16384);
> +		ring_qsize = min(pool->p.pool_size, PAGE_POOL_MAX_RING_SIZE);
>   
>   	/* DMA direction is either DMA_FROM_DEVICE or DMA_BIDIRECTIONAL.
>   	 * DMA_BIDIRECTIONAL is for allowing page used for DMA sending,
> 
> base-commit: 327c20c21d80e0d87834b392d83ae73c955ad8ff